Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Revert the Revert of "[Alerting] renames Resolved action group to Recovered (#84123)" (#84662) #84685

Closed
wants to merge 1 commit into from

Conversation

gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Dec 1, 2020

Backports the following commits to 7.x:

…overed (elastic#84123)"  (elastic#84662)

Reapplies the elastic#84123 PR:
This PR changes the default term from “Resolved” to “Recovered”, as it fits most use cases and we feel users are most likely to understand its meaning across domains.
# Conflicts:
#	x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts
#	x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts
#	x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts
#	x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_form.tsx
@gmmorris
Copy link
Contributor Author

gmmorris commented Dec 1, 2020

This PR clashed with #84662 due to a missing backport.
Closing until that backport is merged.

@gmmorris gmmorris closed this Dec 1, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB +3.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerts 66.4KB 66.4KB +7.0B
triggersActionsUi 161.4KB 161.4KB +4.0B
total +11.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants