[ML] Improve messaging and support for datafeed using aggregated and scripted fields

x-pack/plugins/ml/common/types/anomaly_detection_jobs/summary_job.ts

@@ -28,6 +28,7 @@ export interface MlSummaryJob {
   nodeName?: string;
   auditMessage?: Partial<AuditMessage>;
   isSingleMetricViewerJob: boolean;
+  isNotSingleMetricViewerJobMessage?: string;
   deleting?: boolean;
   latestTimestampSortValue?: number;
   earliestStartTimestampMs?: number;
@@ -45,6 +46,8 @@ export interface AuditMessage {
 export type MlSummaryJobs = MlSummaryJob[];
 
 export interface MlJobWithTimeRange extends CombinedJobWithStats {
+  id: string;
+  isNotSingleMetricViewerJobMessage?: string;
   timeRange: {
     from: number;
     to: number;

x-pack/plugins/ml/common/util/datafeed_utils.ts

@@ -6,12 +6,16 @@
 
 import { Aggregation, Datafeed } from '../types/anomaly_detection_jobs';
 
+export function getAggregations<T>(obj: any): T | undefined {
+  if (obj?.aggregations !== undefined) return obj.aggregations;
+  if (obj?.aggs !== undefined) return obj.aggs;
+  return undefined;
+}
+
 export const getDatafeedAggregations = (
   datafeedConfig: Partial<Datafeed> | undefined
 ): Aggregation | undefined => {
-  if (datafeedConfig?.aggregations !== undefined) return datafeedConfig.aggregations;
-  if (datafeedConfig?.aggs !== undefined) return datafeedConfig.aggs;
-  return undefined;
+  return getAggregations<Aggregation>(datafeedConfig);
 };
 
 export const getAggregationBucketsName = (aggregations: any): string | undefined => {

x-pack/plugins/ml/common/util/job_utils.ts

@@ -10,6 +10,7 @@ import moment, { Duration } from 'moment';
 // @ts-ignore
 import numeral from '@elastic/numeral';
 
+import { i18n } from '@kbn/i18n';
 import { ALLOWED_DATA_UNITS, JOB_ID_MAX_LENGTH } from '../constants/validation';
 import { parseInterval } from './parse_interval';
 import { maxLengthValidator } from './validators';
@@ -20,7 +21,12 @@ import { MlServerLimits } from '../types/ml_server_info';
 import { JobValidationMessage, JobValidationMessageId } from '../constants/messages';
 import { ES_AGGREGATION, ML_JOB_AGGREGATION } from '../constants/aggregation_types';
 import { MLCATEGORY } from '../constants/field_types';
-import { getDatafeedAggregations } from './datafeed_utils';
+import {
+  getAggregationBucketsName,
+  getAggregations,
+  getDatafeedAggregations,
+} from './datafeed_utils';
+import { findAggField } from './validation_utils';
 
 export interface ValidationResults {
   valid: boolean;
@@ -43,20 +49,8 @@ export function calculateDatafeedFrequencyDefaultSeconds(bucketSpanSeconds: numb
   return freq;
 }
 
-// Returns a flag to indicate whether the job is suitable for viewing
-// in the Time Series dashboard.
 export function isTimeSeriesViewJob(job: CombinedJob): boolean {
-  // only allow jobs with at least one detector whose function corresponds to
-  // an ES aggregation which can be viewed in the single metric view and which
-  // doesn't use a scripted field which can be very difficult or impossible to
-  // invert to a reverse search, or when model plot has been enabled.
-  for (let i = 0; i < job.analysis_config.detectors.length; i++) {
-    if (isTimeSeriesViewDetector(job, i)) {
-      return true;
-    }
-  }
-
-  return false;
+  return getSingleMetricViewerJobErrorMessage(job) === undefined;
 }
 
 // Returns a flag to indicate whether the detector at the index in the specified job
@@ -99,6 +93,24 @@ export function isSourceDataChartableForDetector(job: CombinedJob, detectorIndex
         scriptFields.indexOf(dtr.by_field_name!) === -1 &&
         scriptFields.indexOf(dtr.over_field_name!) === -1;
     }
+
+    // We cannot plot the source data for some specific aggregation configurations
+    const hasDatafeed =
+      typeof job.datafeed_config === 'object' && Object.keys(job.datafeed_config).length > 0;
+    if (hasDatafeed) {
+      const aggs = getDatafeedAggregations(job.datafeed_config);
+      if (aggs !== undefined) {
+        const aggBucketsName = getAggregationBucketsName(aggs);
+        if (aggBucketsName !== undefined) {
+          // if fieldName is a aggregated field under nested terms using bucket_script
+          const aggregations = getAggregations<{ [key: string]: any }>(aggs[aggBucketsName]) ?? {};
+          const foundField = findAggField(aggregations, dtr.field_name, false);
+          if (foundField?.bucket_script !== undefined) {
+            return false;
+          }
+        }
+      }
+    }
   }
 
   return isSourceDataChartable;
@@ -134,6 +146,24 @@ export function isModelPlotChartableForDetector(job: Job, detectorIndex: number)
   return isModelPlotChartable;
 }
 
+// Returns a reason to indicate why the job configuration is not supported
+// if the result is undefined, that means the single metric job should be viewable
+export function getSingleMetricViewerJobErrorMessage(job: CombinedJob): string | undefined {
+  // only allow jobs with at least one detector whose function corresponds to
+  // an ES aggregation which can be viewed in the single metric view and which
+  // doesn't use a scripted field which can be very difficult or impossible to
+  // invert to a reverse search, or when model plot has been enabled.
+  const isChartableTimeSeriesViewJob = job.analysis_config.detectors.some((detector, idx) =>
+    isTimeSeriesViewDetector(job, idx)
+  );
+
+  if (isChartableTimeSeriesViewJob === false) {
+    return i18n.translate('xpack.ml.timeSeriesJob.notViewableTimeSeriesJobMessage', {
+      defaultMessage: 'not a viewable time series job',
+    });
+  }
+}
+
 // Returns the names of the partition, by, and over fields for the detector with the
 // specified index from the supplied ML job configuration.
 export function getPartitioningFieldNames(job: CombinedJob, detectorIndex: number): string[] {

x-pack/plugins/ml/common/util/validation_utils.ts

@@ -32,15 +32,20 @@ export function isValidJson(json: string) {
   }
 }
 
-export function findAggField(aggs: Record<string, any>, fieldName: string): any {
+export function findAggField(
+  aggs: Record<string, any> | { [key: string]: any },
+  fieldName: string | undefined,
+  returnParent: boolean = false
+): any {
+  if (fieldName === undefined) return;
   let value;
   Object.keys(aggs).some(function (k) {
     if (k === fieldName) {
-      value = aggs[k];
+      value = returnParent === true ? aggs : aggs[k];
       return true;
     }
     if (aggs.hasOwnProperty(k) && typeof aggs[k] === 'object') {
-      value = findAggField(aggs[k], fieldName);
+      value = findAggField(aggs[k], fieldName, returnParent);
       return value !== undefined;
     }
   });

x-pack/plugins/ml/public/application/components/custom_hooks/use_create_ad_links.ts

@@ -22,13 +22,14 @@ export const useCreateADLinks = () => {
   const userTimeSettings = useUiSettings().get(ANOMALY_DETECTION_DEFAULT_TIME_RANGE);
   const createLinkWithUserDefaults = useCallback(
     (location, jobList) => {
-      return mlJobService.createResultsUrlForJobs(
+      const resultsUrl = mlJobService.createResultsUrlForJobs(
         jobList,
         location,
         useUserTimeSettings === true && userTimeSettings !== undefined
           ? userTimeSettings
           : undefined
       );
+      return `${basePath.get()}/app/ml/${resultsUrl}`;
     },
     [basePath]
   );

x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/back_to_list_panel/back_to_list_panel.tsx

@@ -7,21 +7,13 @@
 import React, { FC, Fragment } from 'react';
 import { EuiCard, EuiIcon } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import { useMlKibana, useMlUrlGenerator } from '../../../../../contexts/kibana';
+import { useMlLink } from '../../../../../contexts/kibana';
 import { ML_PAGES } from '../../../../../../../common/constants/ml_url_generator';
 
 export const BackToListPanel: FC = () => {
-  const urlGenerator = useMlUrlGenerator();
-  const {
-    services: {
-      application: { navigateToUrl },
-    },
-  } = useMlKibana();
-
-  const redirectToAnalyticsManagementPage = async () => {
-    const url = await urlGenerator.createUrl({ page: ML_PAGES.DATA_FRAME_ANALYTICS_JOBS_MANAGE });
-    await navigateToUrl(url);
-  };
+  const analyticsManagementPageLink = useMlLink({
+    page: ML_PAGES.DATA_FRAME_ANALYTICS_JOBS_MANAGE,
+  });
 
   return (
     <Fragment>
@@ -37,7 +29,7 @@ export const BackToListPanel: FC = () => {
             defaultMessage: 'Return to the analytics management page.',
           }
         )}
-        onClick={redirectToAnalyticsManagementPage}
+        href={analyticsManagementPageLink}
         data-test-subj="analyticsWizardCardManagement"
       />
     </Fragment>

x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/view_results_panel/view_results_panel.tsx

@@ -7,29 +7,22 @@
 import React, { FC, Fragment } from 'react';
 import { EuiCard, EuiIcon } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import { useMlUrlGenerator } from '../../../../../contexts/kibana';
+import { useMlLink } from '../../../../../contexts/kibana';
 import { ML_PAGES } from '../../../../../../../common/constants/ml_url_generator';
-import { useNavigateToPath } from '../../../../../contexts/kibana';
 import { DataFrameAnalysisConfigType } from '../../../../../../../common/types/data_frame_analytics';
 interface Props {
   jobId: string;
   analysisType: DataFrameAnalysisConfigType;
 }
 
 export const ViewResultsPanel: FC<Props> = ({ jobId, analysisType }) => {
-  const urlGenerator = useMlUrlGenerator();
-  const navigateToPath = useNavigateToPath();
-
-  const redirectToAnalyticsExplorationPage = async () => {
-    const path = await urlGenerator.createUrl({
-      page: ML_PAGES.DATA_FRAME_ANALYTICS_EXPLORATION,
-      pageState: {
-        jobId,
-        analysisType,
-      },
-    });
-    await navigateToPath(path);
-  };
+  const analyticsExplorationPageLink = useMlLink({
+    page: ML_PAGES.DATA_FRAME_ANALYTICS_EXPLORATION,
+    pageState: {
+      jobId,
+      analysisType,
+    },
+  });
 
   return (
     <Fragment>
@@ -45,7 +38,7 @@ export const ViewResultsPanel: FC<Props> = ({ jobId, analysisType }) => {
             defaultMessage: 'View results for the analytics job.',
           }
         )}
-        onClick={redirectToAnalyticsExplorationPage}
+        href={analyticsExplorationPageLink}
         data-test-subj="analyticsWizardViewResultsCard"
       />
     </Fragment>

x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container.js

@@ -31,6 +31,7 @@ import { MlTooltipComponent } from '../../components/chart_tooltip';
 import { withKibana } from '../../../../../../../src/plugins/kibana_react/public';
 import { ML_APP_URL_GENERATOR } from '../../../../common/constants/ml_url_generator';
 import { addItemToRecentlyAccessed } from '../../util/recently_accessed';
+import { ExplorerChartsErrorCallOuts } from './explorer_charts_error_callouts';
 
 const textTooManyBuckets = i18n.translate('xpack.ml.explorer.charts.tooManyBucketsDescription', {
   defaultMessage:
@@ -165,6 +166,7 @@ export const ExplorerChartsContainerUI = ({
   severity,
   tooManyBuckets,
   kibana,
+  errorMessages,
 }) => {
   const {
     services: {
@@ -183,27 +185,29 @@ export const ExplorerChartsContainerUI = ({
   const chartsColumns = chartsPerRow === 1 ? 0 : chartsPerRow;
 
   const wrapLabel = seriesToPlot.some((series) => isLabelLengthAboveThreshold(series));
-
   return (
-    <EuiFlexGrid columns={chartsColumns}>
-      {seriesToPlot.length > 0 &&
-        seriesToPlot.map((series) => (
-          <EuiFlexItem
-            key={getChartId(series)}
-            className="ml-explorer-chart-container"
-            style={{ minWidth: chartsWidth }}
-          >
-            <ExplorerChartContainer
-              series={series}
-              severity={severity}
-              tooManyBuckets={tooManyBuckets}
-              wrapLabel={wrapLabel}
-              navigateToApp={navigateToApp}
-              mlUrlGenerator={mlUrlGenerator}
-            />
-          </EuiFlexItem>
-        ))}
-    </EuiFlexGrid>
+    <>
+      <ExplorerChartsErrorCallOuts errorMessagesByType={errorMessages} />
+      <EuiFlexGrid columns={chartsColumns}>
+        {seriesToPlot.length > 0 &&
+          seriesToPlot.map((series) => (
+            <EuiFlexItem
+              key={getChartId(series)}
+              className="ml-explorer-chart-container"
+              style={{ minWidth: chartsWidth }}
+            >
+              <ExplorerChartContainer
+                series={series}
+                severity={severity}
+                tooManyBuckets={tooManyBuckets}
+                wrapLabel={wrapLabel}
+                navigateToApp={navigateToApp}
+                mlUrlGenerator={mlUrlGenerator}
+              />
+            </EuiFlexItem>
+          ))}
+      </EuiFlexGrid>
+    </>
   );
 };
 

x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container_service.d.ts

@@ -4,11 +4,17 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import type { JobId } from '../../../../common/types/anomaly_detection_jobs';
+
+export interface ExplorerChartSeriesErrorMessages {
+  [key: string]: Set<JobId>;
+}
 export declare interface ExplorerChartsData {
   chartsPerRow: number;
   seriesToPlot: any[];
   tooManyBuckets: boolean;
   timeFieldName: string;
+  errorMessages: ExplorerChartSeriesErrorMessages;
 }
 
 export declare const getDefaultChartsData: () => ExplorerChartsData;