Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended #84415

Merged
merged 7 commits into from
Nov 30, 2020
Merged

[APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended #84415

merged 7 commits into from
Nov 30, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #84185

Screenshot 2020-11-26 at 14 45 51

Screenshot 2020-11-26 at 14 47 47

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 26, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner November 26, 2020 14:07
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes mentioned this pull request Nov 26, 2020
Closed
10 tasks
formgeist
formgeist approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anomaly scores and stream look great 👍

Two visual issues that I spotted;

  • The actual chart height is somehow a lot smaller than previously.
  • The link to the ML job reads: Machine Learning: View job: - should get rid of that last :

Screenshot 2020-11-26 at 15 33 34

@cauemarcondes
Copy link
Contributor Author

The link to the ML job reads: Machine Learning: View job: - should get rid of that last :

I'm going to remove the extra : on this PR.

@cauemarcondes cauemarcondes requested a review from a team November 26, 2020 15:22
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit about the structure of anomalySeries

@cauemarcondes
Copy link
Contributor Author

@sqren I'm going to merge this PR when the CI passes and if I see that the anomalies boundaries are really positioned wrongly I'll create a new issue. I need this to be able to implement the Latency chart in the Service Overview page.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +2.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 416dbde into elastic:master Nov 30, 2020
@cauemarcondes cauemarcondes deleted the apm-ml-annomalies-chart branch November 30, 2020 15:18
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Nov 30, 2020
@cauemarcondes @kibanamachine
[APM] ML anomaly detection integration: Displaying anomaly job result…
e47f185 
…s in the Transaction duration chart is not as intended (elastic#84415)

* adding anomalies to transaction duration chart

* removing extra :

* fixing test

* addressing pr comments

* addressing pr comments

Co-authored-by: Kibana Machine <[email protected]>
@cauemarcondes cauemarcondes mentioned this pull request Nov 30, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 30, 2020
@phillipb
Merge branch 'add-metadata-to-node-details' of github.com:phillipb/ki…
6a491e8 
…bana into add-metadata-to-node-details

* 'add-metadata-to-node-details' of github.com:phillipb/kibana:
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  [ML] Renaming saved object repair to sync (elastic#84311)
  [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313)
  [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456)
  [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322)
  TSVB field list performance issue on using annotations (elastic#84407)
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 30, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
e066f65 
* master: (25 commits)
  [Alerting] fixes buggy default message behaviour (elastic#84202)
  [Graph] Use new ES client and change license API (elastic#84398)
  [DOCS] Adds redirect to known plugins page (elastic#84001)
  Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376)
  Adding timestamps to created events so the sorting is stable (elastic#84515)
  [DOCS] Redirects for drilldown links (elastic#83846)
  [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805)
  [Enterprise Search] Migrate shared Schema components (elastic#84381)
  [Discover] Unskip date_nanos and shard links functional tests (elastic#82878)
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  ...
cauemarcondes added a commit that referenced this pull request Dec 1, 2020
@cauemarcondes @kibanamachine
[APM] ML anomaly detection integration: Displaying anomaly job result…
941b3e7 
…s in the Transaction duration chart is not as intended (#84415) (#84524)

* adding anomalies to transaction duration chart

* removing extra :

* fixing test

* addressing pr comments

* addressing pr comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@formgeist formgeist formgeist approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
5 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @formgeist