[backport] PR #8371 to 5.0 #8425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- **Commit 1:** fixing charts to not render twice * Original sha: f7f0f12 * Authored by ppisljar <[email protected]> on 2016-09-20T08:55:55Z **Commit 2:** fixing tests * Original sha: 40234e8 * Authored by ppisljar <[email protected]> on 2016-09-21T07:21:01Z **Commit 3:** fixing based on Spencers comments * Original sha: cdad772 * Authored by ppisljar <[email protected]> on 2016-09-21T19:41:57Z (cherry picked from commit 61d487c)
ppisljar
force-pushed
the
jasper/backport/8371/5.0
branch
from
596f5fc to
481fcff
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #8371
Commit 1:
fixing charts to not render twice
Commit 2:
fixing tests
Commit 3:
fixing based on Spencers comments