Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v24.2.0 #84223

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 24, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 24.0.0 -> 24.2.0 age adoption passing confidence

Release Notes

elastic/elastic-charts

v24.2.0

Compare Source

Bug Fixes
  • near and far alignments for orthogonal rotations (#​911) (cb279f3)
Features

v24.1.0

Compare Source

Bug Fixes
Features

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:Operations Team label for Operations Team v7.10.0 v8.0.0 labels Nov 24, 2020
@renovate renovate bot requested a review from markov00 November 24, 2020 14:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

yarn.lock Outdated
Comment on lines 1403 to 1405
"@elastic/datemath@link:packages/elastic-datemath":
version "0.0.0"
uid ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spalger is this expected? Seems a bit strange.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems that renovate isn't doing the right thing here, when I make a change to the yarn.lock file locally all those changes get reverted :/ I'll fix up this PR and file an issue with them.

@markov00
Copy link
Member

@elastic/kibana-operations what are all those changes at the yarn.lock file? Seems outside of the scope for this single dependency upgrade

@spalger
Copy link
Contributor

spalger commented Nov 24, 2020

@nickofthyme @markov00 can we wait a little while before merging this to give the renovate folks a chance to debug these yarn.lock issues? Having this as a reproduction for my issue would be nice.

Issue: renovatebot/renovate#7806

@markov00
Copy link
Member

Hey @spalger I've seen Renovatebot folks have replyed, can we go on, rebase and merge?

@renovate renovate bot changed the title Update dependency @elastic/charts to v24.1.0 Update dependency @elastic/charts to v24.2.0 Nov 30, 2020
@spalger
Copy link
Contributor

spalger commented Nov 30, 2020

Looks like the renovate issue is fixed now, LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +81.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 547.1KB 546.8KB -360.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
[email protected] 2.4MB 2.4MB +17.7KB
kbn-ui-shared-deps.js 13.6MB 13.6MB +22.0B
total +17.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markov00 markov00 merged commit 647b991 into master Nov 30, 2020
@renovate renovate bot deleted the renovate/@elasticcharts branch November 30, 2020 17:44
markov00 pushed a commit to markov00/kibana that referenced this pull request Nov 30, 2020
markov00 added a commit that referenced this pull request Dec 1, 2020
Co-authored-by: Renovate Bot <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants