Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [TSVB] Custom renderer (#83554) #84118

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

sulemanof
Copy link
Contributor

Backports the following commits to 7.x:

* Implement custom renderer

* Remove legacy code

* Use custom expression

* Convert to typescript

* Remove savedObjectId extra param

* Other updates

* Fix types

* Cleanup

* Fix functional tests

* Bind uiSettings

* Update snapshot

* Update types

* Remove extra params

* Move common types

* Return back validation error message

* Use panel types enum

* Fix types

* Lazy load visualizations
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 469 470 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.7MB 1.8MB +83.9KB

Distributable file count

id before after diff
default 43363 43396 +33
oss 22845 22878 +33

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimeseries 135.1KB 137.2KB +2.1KB
visualizations 170.1KB 169.2KB -946.0B
total +1.2KB
Unknown metric groups

async chunk count

id before after diff
visTypeTimeseries 1 12 +11

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit f13550b into elastic:7.x Nov 23, 2020
@sulemanof sulemanof deleted the backport/7.x/pr-83554 branch November 23, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants