Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for x-pack maps functional test to remove the unloading of data #83856

Merged
merged 17 commits into from
Nov 23, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

... for the subsequent maps tests to pass.

@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner November 19, 2020 20:08
@rashmivkulkarni rashmivkulkarni self-assigned this Nov 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@rashmivkulkarni rashmivkulkarni added the release_note:skip Skip the PR/issue when compiling release notes label Nov 19, 2020
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the before block from this test. The data is loaded in the index file.

Can you do the same for maps_spaces functional test?

@nreese nreese added v7.11.0 and removed v7.10.0 labels Nov 19, 2020
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the maps functional tests.
LGTM
code review

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni merged commit ac1cf7d into elastic:master Nov 23, 2020
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Nov 23, 2020
…lastic#83856)

* fixes elastic#74449

* fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass

* changes to how we  load/unload data

* modified index.js file again to fit the needs

Co-authored-by: Kibana Machine <[email protected]>
rashmivkulkarni added a commit that referenced this pull request Nov 24, 2020
…83856) (#84166)

* fixes #74449

* fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass

* changes to how we  load/unload data

* modified index.js file again to fit the needs

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Nov 30, 2020
…lastic#83856)

* fixes elastic#74449

* fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass

* changes to how we  load/unload data

* modified index.js file again to fit the needs

Co-authored-by: Kibana Machine <[email protected]>
rashmivkulkarni added a commit that referenced this pull request Dec 1, 2020
…83856) (#84597)

* fixes #74449

* fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass

* changes to how we  load/unload data

* modified index.js file again to fit the needs

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants