-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for x-pack maps functional test to remove the unloading of data #83856
Conversation
…equent tests to pass
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove the before block from this test. The data is loaded in the index file.
Can you do the same for maps_spaces functional test?
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the maps functional tests.
LGTM
code review
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…lastic#83856) * fixes elastic#74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <[email protected]>
…83856) (#84166) * fixes #74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…lastic#83856) * fixes elastic#74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <[email protected]>
…83856) (#84597) * fixes #74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
... for the subsequent maps tests to pass.