Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update absolute time picker when time selection changes. #8383

Merged

Conversation

stacey-gammon
Copy link
Contributor

Listen for changes being made to the to and from attributes in the absolute time picker, otherwise time selection changes will not be immediately reflected in the time picker.

Fixes #6726

Listen for changes made to timefilter.time and update the absolute time
picker accordingly.
@tsullivan
Copy link
Member

LGTM!

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@stacey-gammon stacey-gammon merged commit 935b812 into elastic:master Sep 20, 2016
elastic-jasper added a commit that referenced this pull request Sep 20, 2016
---------

**Commit 1:**
Update absolute time picker when time selection changes.

Listen for changes made to timefilter.time and update the absolute time
picker accordingly.

* Original sha: 12f61e1
* Authored by Stacey-Gammon <[email protected]> on 2016-09-20T19:41:50Z
elastic-jasper added a commit that referenced this pull request Sep 20, 2016
---------

**Commit 1:**
Update absolute time picker when time selection changes.

Listen for changes made to timefilter.time and update the absolute time
picker accordingly.

* Original sha: 12f61e1
* Authored by Stacey-Gammon <[email protected]> on 2016-09-20T19:41:50Z
elastic-jasper added a commit that referenced this pull request Sep 20, 2016
---------

**Commit 1:**
Update absolute time picker when time selection changes.

Listen for changes made to timefilter.time and update the absolute time
picker accordingly.

* Original sha: 12f61e1
* Authored by Stacey-Gammon <[email protected]> on 2016-09-20T19:41:50Z
stacey-gammon added a commit that referenced this pull request Sep 20, 2016
[backport] PR #8383 to 5.0 - Update absolute time picker when time selection changes.
stacey-gammon added a commit that referenced this pull request Sep 20, 2016
[backport] PR #8383 to 5.x - Update absolute time picker when time selection changes.
stacey-gammon added a commit that referenced this pull request Sep 21, 2016
---------

**Commit 1:**
Update absolute time picker when time selection changes.

Listen for changes made to timefilter.time and update the absolute time
picker accordingly.

* Original sha: 12f61e1
* Authored by Stacey-Gammon <[email protected]> on 2016-09-20T19:41:50Z
stacey-gammon added a commit that referenced this pull request Sep 21, 2016
[backport] PR #8383 to 4.6 - Update absolute time picker when time selection changes.
@stacey-gammon stacey-gammon deleted the bug/6726/refresh-timepicker branch December 19, 2016 15:45
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
---------

**Commit 1:**
Update absolute time picker when time selection changes.

Listen for changes made to timefilter.time and update the absolute time
picker accordingly.

* Original sha: 7665e464adcb2163ec8790b97ca01169f5b513bf [formerly 12f61e1]
* Authored by Stacey-Gammon <[email protected]> on 2016-09-20T19:41:50Z


Former-commit-id: 5a356db
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[backport] PR elastic#8383 to 5.x - Update absolute time picker when time selection changes.

Former-commit-id: 7e82f9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants