Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime]Refactor header and action menu #83779

Merged
merged 33 commits into from
Dec 9, 2020
Merged

[Uptime]Refactor header and action menu #83779

merged 33 commits into from
Dec 9, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 19, 2020 •
edited
Loading

Summary

Fixes: #83666

Aligned uptime nav with APM/Logs/Metrics,

Moved alerts and add data button to kibana action menu.

Changed add data button icon.

Certificate and settings page is now a tab.

image

@shahzad31 shahzad31 marked this pull request as ready for review November 30, 2020 18:42
@shahzad31 shahzad31 requested a review from a team as a code owner November 30, 2020 18:42
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Nov 30, 2020
@katrin-freihofner
Copy link
Contributor

In general, this looks good.
I was surprised that we are moving to tabs, did I miss something? cc @drewpost
I don't think that the term 'Overview' works great in a tab - I suggest something like 'Monitor list'.

I wasn't sure what the refresh button in the certificate list adds, do we need that? Is that the same as the browser refresh?
Screenshot 2020-12-02 at 12 07 12

I don't think we need a time selector for the settings.
Screenshot 2020-12-02 at 12 07 07

@paulb-elastic
Copy link
Contributor

@katrin-freihofner I understand this is part of the Header Layout Change update (which follows on from APM's update)
/cc @formgeist @drewpost @shahzad31

@drewpost
Copy link

drewpost commented Dec 2, 2020

I don't have strong feelings about "Overview" but I'm curious to know a bit more about why you don't like it @katrin-freihofner. I worry about using "Monitors" as a header as the term is overloaded. You could argue that certificates are certificate monitors too.

@katrin-freihofner
Copy link
Contributor

Seems like I was not up-to-date on this issue, so forget what I said.

Kerry350
Kerry350 approved these changes Dec 6, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

x-pack/plugins/uptime/public/components/certificates/cert_refresh_btn.tsx Outdated Show resolved Hide resolved
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Dec 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 540 543 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1006.1KB 1005.8KB -267.0B

Distributable file count

id before after diff
default 46960 47720 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 2a8c609 into elastic:master Dec 9, 2020
@shahzad31 shahzad31 deleted the uptime-action-menu branch December 9, 2020 11:45
@shahzad31 shahzad31 mentioned this pull request Dec 9, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Dec 9, 2020
@shahzad31 @kibanamachine
[Uptime]Refactor header and action menu (elastic#83779)
631abd2 
Co-authored-by: Kibana Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Dec 9, 2020
@shahzad31 @kibanamachine
[7.x] [Uptime]Refactor header and action menu (#83779) (#85395)
4e27e5c 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 9, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/add-shrin…
0e2c525 
…k-field-to-hot-phase

* 'master' of github.com:elastic/kibana: (429 commits)
  simplify popover open state logic (elastic#85379)
  [Logs UI][Metrics UI] Move actions to the kibana header (elastic#84648)
  [Search Source] Do not pick scripted fields if * provided (elastic#85133)
  [Search] Session SO polling (elastic#84225)
  [Transform] Replace legacy elasticsearch client (elastic#84932)
  [Uptime]Refactor header and action menu (elastic#83779)
  Fix agg select external link (elastic#85380)
  [ILM] Show forcemerge in hot when rollover is searchable snapshot is enabled (elastic#85292)
  clear using keyboard (elastic#85042)
  [GS] add tag and dashboard suggestion results (elastic#85144)
  [ML] API integration tests - skip GetAnomaliesTableData
  Add ECS field for event.code. (elastic#85109)
  [Functional][TSVB] Wait for markdown textarea to be cleaned (elastic#85128)
  skip flaky suite (elastic#62060)
  skip flaky suite (elastic#85098)
  Bump highlight.js to v9.18.5 (elastic#84296)
  Add `server.publicBaseUrl` config (elastic#85075)
  [Alerting & Actions ] More debug logging (elastic#85149)
  [Security Solution][Case] Manual attach alert to a case (elastic#82996)
  Loosen UUID regex to accept uuidv1 or uuidv4 (elastic#85338)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/index.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts
#	x-pack/plugins/index_lifecycle_management/server/routes/api/policies/register_create_route.ts
@dominiqueclarke dominiqueclarke mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

@katrin-freihofner katrin-freihofner Awaiting requested review from katrin-freihofner

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Header layout changes
7 participants
@shahzad31 @katrin-freihofner @paulb-elastic @drewpost @elasticmachine @kibanamachine @Kerry350