Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime]Reduce chart height on monitor detail page #83777

Merged
merged 2 commits into from
Nov 20, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { ChartEmptyState } from './chart_empty_state';
import { DurationAnomaliesBar } from './duration_line_bar_list';
import { AnomalyRecords } from '../../../state/actions';
import { UptimeThemeContext } from '../../../contexts';
import { MONITOR_CHART_HEIGHT } from '../../monitor';

interface DurationChartProps {
/**
Expand Down Expand Up @@ -86,7 +87,7 @@ export const DurationChartComponent = ({
};

return (
<ChartWrapper height="400px" loading={loading}>
<ChartWrapper height={MONITOR_CHART_HEIGHT} loading={loading}>
{hasLines ? (
<Chart>
<Settings
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { MonitorDuration } from './monitor_duration/monitor_duration_container';
interface MonitorChartsProps {
monitorId: string;
}
export const MONITOR_CHART_HEIGHT = '250px';
shahzad31 marked this conversation as resolved.
Show resolved Hide resolved

export const MonitorCharts = ({ monitorId }: MonitorChartsProps) => {
return (
Expand All @@ -20,7 +21,7 @@ export const MonitorCharts = ({ monitorId }: MonitorChartsProps) => {
<MonitorDuration monitorId={monitorId} />
</EuiFlexItem>
<EuiFlexItem>
<PingHistogram height="400px" isResponsive={false} />
<PingHistogram height={MONITOR_CHART_HEIGHT} isResponsive={false} />
</EuiFlexItem>
</EuiFlexGroup>
);
Expand Down