Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node.js from 12.19.0 to 12.19.1 #83452

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

watson
Copy link
Contributor

@watson watson commented Nov 16, 2020

No description provided.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 16, 2020
@watson watson self-assigned this Nov 16, 2020
@watson watson requested a review from a team November 16, 2020 17:27
@jportner jportner self-requested a review November 16, 2020 18:12
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this is working great.

I noticed this is unchanged:

kibana/.ci/Dockerfile

Lines 4 to 6 in fb6d136

ARG NODE_VERSION=12.19.0
FROM node:${NODE_VERSION} AS base

I checked Docker Hub and it doesn't appear that a 12.19.1 image is available yet: https://hub.docker.com/_/node?tab=description

However, this was merged in the docker-node repo a couple of hours ago: nodejs/docker-node@ba99d6d

Thoughts?

@watson
Copy link
Contributor Author

watson commented Nov 16, 2020

@jportner Yeah I left it out because Docker Hub hasn't been updated yet and it's ok that Docker doesn't run the exact same version. As I understand it, this version is just used for build-purposes and doesn't influence the CI run directly. So we've previously updated that version separately if we needed to get an update out quickly. However, in this particular instance, we're not in a hurry, so we can wait if we want to.

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, this version is just used for build-purposes and doesn't influence the CI run directly. So we've previously updated that version separately if we needed to get an update out quickly. However, in this particular instance, we're not in a hurry, so we can wait if we want to.

Thanks for the explanation! I'll approve now and leave that decision up to you 😄

@watson
Copy link
Contributor Author

watson commented Nov 16, 2020

Docker Hub was updated quickly this time, so I could add it already now

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #88074 succeeded f6c72f1e82a1bc45638f155f155c41f65a6a0819

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants