-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Node.js from 12.19.0 to 12.19.1 #83452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and this is working great.
I noticed this is unchanged:
Lines 4 to 6 in fb6d136
ARG NODE_VERSION=12.19.0 | |
FROM node:${NODE_VERSION} AS base |
I checked Docker Hub and it doesn't appear that a 12.19.1 image is available yet: https://hub.docker.com/_/node?tab=description
However, this was merged in the docker-node
repo a couple of hours ago: nodejs/docker-node@ba99d6d
Thoughts?
@jportner Yeah I left it out because Docker Hub hasn't been updated yet and it's ok that Docker doesn't run the exact same version. As I understand it, this version is just used for build-purposes and doesn't influence the CI run directly. So we've previously updated that version separately if we needed to get an update out quickly. However, in this particular instance, we're not in a hurry, so we can wait if we want to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, this version is just used for build-purposes and doesn't influence the CI run directly. So we've previously updated that version separately if we needed to get an update out quickly. However, in this particular instance, we're not in a hurry, so we can wait if we want to.
Thanks for the explanation! I'll approve now and leave that decision up to you 😄
f6c72f1
to
7150960
Compare
Docker Hub was updated quickly this time, so I could add it already now |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
No description provided.