[ML] Persisted URL state for the Data frame analytics jobs and models pages #83439

darnautov · 2020-11-16T15:55:16Z

Summary

Part of #83033

Adds persisted URL state on the Data frame analytics jobs and models listing page with the following parameters:
- Selected filters
- Pagination
  - Active page
  - Page size
- Sorting
  - Sort field
  - Sort direction
Fixes "ID" column configuration issue caused an error during pagination and sorting changes.
Updates the Anomaly Detection jobs page state with a prefix

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

…-url-state

elasticmachine · 2020-11-16T15:55:18Z

Pinging @elastic/ml-ui (:ml)

apmmachine · 2020-11-16T16:01:56Z

💚 Build Succeeded

pipeline
Commit: 045fa80

alvarezmelissa87 · 2020-11-16T18:28:46Z

x-pack/plugins/ml/public/ml_url_generator/ml_url_generator.test.ts

@@ -190,7 +192,9 @@ describe('MlUrlGenerator', () => {
            groupIds: ['group_1', 'group_2'],
          },
        });
-        expect(url).toBe('/app/ml/data_frame_analytics?mlManagement=(groupIds:!(group_1,group_2))');
+        expect(url).toBe(
+          "/app/ml/data_frame_analytics?_a=(data_frame_analytics:(queryText:'groups:(group_1%20or%20group_2)'))"


We should let APM and Metrics team know that this is changing as I believe they may be using the old query param setup to filter the jobs list via the url. cc @phillipb, @sqren
Though if the url generator is available externally and being used, it shouldn't be too big of an issue.

alvarezmelissa87

Tested and LGTM ⚡

...on/data_frame_analytics/pages/analytics_management/components/analytics_list/use_columns.tsx

...data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx

elasticmachine · 2020-11-17T11:10:56Z

Pinging @elastic/apm-ui (Team:apm)

peteharverson

Tested latest edits and LGTM

kibanamachine · 2020-11-17T12:51:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4c6b00b

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	5.2MB	5.2MB	+373.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	66.8KB	67.3KB	+485.0B

History

💔 Build #88251 failed 7c4a4c8
💚 Build #88038 succeeded 045fa80

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (51 commits) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) skip flaky suite (elastic#77279) [ML] Improve support for script and aggregation fields in anomaly detection jobs (elastic#81923) [Workplace Search] Migrate SourcesLogic from ent-search (elastic#83544) [ML] Add UI test for feature importance features (elastic#82677) [Maps] Improve icons for all layer types (elastic#83503) Replace experimental badge with Beta (elastic#83468) [Fleet][EPM] Unified install and archive (elastic#83384) Move src/legacy/server/keystore to src/cli (elastic#83483) Used SO for saving the API key IDs that should be deleted (elastic#82211) [Uptime] Mock implementation to account for math flakiness test (elastic#83535) [Workplace Search] Enable check for org context based on URL (elastic#83487) [App Search] Added all Document related routes and logic (elastic#83324) [Alerting UI] Fix console error when setting connector params (elastic#83333) [Discover] Allow custom name for fields via index pattern field management (elastic#70039) [Uptime] Fix monitor list down histogram (elastic#83411) remove headers timeout hack, rely on nodejs timeouts (elastic#83419) [ML] Update console autocomplete for ML data frame evaluate API (elastic#83151) [Lens] Color in dimension trigger (elastic#76871) ...

… pages (#83439) (#83574) * [ML] support table settings from the URL state * [ML] fix management page * [ML] models page support * [ML] update URL generator * [ML] rename id column * [ML] update types and tests * [ML] fix id column name and field * [ML] remove legacy functions * [ML] set id key for the job query text * [ML] fix id column rendering * [ML] ad jobs with usePageUrlState * [ML] update unit tests for solutions

…o-node-details * 'master' of github.com:elastic/kibana: (65 commits) update chromedriver dependency to 87 (elastic#83624) [TSVB] use new Search API for rollup search (elastic#83275) [TSVB] Y-axis has number formatting not considering all series formatters in the group (elastic#83438) [Logs UI] Update <LogStream /> internal state when its props change (elastic#83302) Add tag bulk action context menu (elastic#82816) [code coverage] adding plugin to flush coverage data (elastic#83447) [UsageCollection] Expose `KibanaRequest` to explicitly opted-in collectors (elastic#83413) Added eventBus to trigger and listen plotHandler event (elastic#83435) [Runtime fields] Editor phase 1 (elastic#81472) [Maps] Fix threshold alert issue resolving nested fields (elastic#83577) chore(NA): remove usage of unverified es snapshots (elastic#83589) [DOCS] Adds Elastic Contributor Program link (elastic#83561) Upgrade EUI to v30.2.0 (elastic#82730) Don't show loading screen during auto-reload (elastic#83376) Functional tests - fix esArchive mappings with runtime fields (elastic#83530) [deb/rpm] Create keystore after installation (elastic#76465) [rpm] Create default environment file at "/etc/sysconfig/kibana" (elastic#82144) [docker] removes workaround for missing crypto-policies-scripts subpackage (elastic#83455) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) ...

darnautov added 7 commits November 16, 2020 10:17

[ML] support table settings from the URL state

f4ea020

[ML] fix management page

ee1e32b

Merge remote-tracking branch 'upstream/master' into ML-83033-dfa-list…

c446270

…-url-state

[ML] models page support

3ffe3f4

[ML] update URL generator

a058c0b

[ML] rename id column

2c5e336

[ML] update types and tests

045fa80

darnautov added release_note:enhancement :ml v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.11.0 labels Nov 16, 2020

darnautov requested review from alvarezmelissa87 and peteharverson November 16, 2020 15:55

darnautov requested a review from a team as a code owner November 16, 2020 15:55

darnautov self-assigned this Nov 16, 2020

darnautov mentioned this pull request Nov 16, 2020

[ML] Persisted state in the URL, improve browser history navigation #83033

Closed

7 tasks

alvarezmelissa87 reviewed Nov 16, 2020

View reviewed changes

alvarezmelissa87 approved these changes Nov 16, 2020

View reviewed changes

peteharverson reviewed Nov 17, 2020

View reviewed changes

...on/data_frame_analytics/pages/analytics_management/components/analytics_list/use_columns.tsx Outdated Show resolved Hide resolved

peteharverson reviewed Nov 17, 2020

View reviewed changes

...data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx Show resolved Hide resolved

darnautov added 4 commits November 17, 2020 10:40

[ML] fix id column name and field

54efa0d

[ML] remove legacy functions

fe2cda6

[ML] set id key for the job query text

aa1f66b

[ML] fix id column rendering

7c4a4c8

darnautov requested a review from peteharverson November 17, 2020 10:12

darnautov added 2 commits November 17, 2020 11:48

[ML] ad jobs with usePageUrlState

15724fc

[ML] update unit tests for solutions

4c6b00b

darnautov requested review from a team as code owners November 17, 2020 11:10

botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 17, 2020

peteharverson approved these changes Nov 17, 2020

View reviewed changes

sorenlouv approved these changes Nov 17, 2020

View reviewed changes

XavierM approved these changes Nov 17, 2020

View reviewed changes

darnautov merged commit bc22b67 into elastic:master Nov 17, 2020

darnautov deleted the ML-83033-dfa-list-url-state branch November 17, 2020 18:29

darnautov mentioned this pull request Nov 17, 2020

[7.x] [ML] Persisted URL state for the Data frame analytics jobs and models pages (#83439) #83574

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Persisted URL state for the Data frame analytics jobs and models pages #83439

[ML] Persisted URL state for the Data frame analytics jobs and models pages #83439

darnautov commented Nov 16, 2020 •

edited

Loading

elasticmachine commented Nov 16, 2020

apmmachine commented Nov 16, 2020

alvarezmelissa87 Nov 16, 2020 •

edited

Loading

alvarezmelissa87 left a comment

elasticmachine commented Nov 17, 2020

peteharverson left a comment

kibanamachine commented Nov 17, 2020

[ML] Persisted URL state for the Data frame analytics jobs and models pages #83439

[ML] Persisted URL state for the Data frame analytics jobs and models pages #83439

Conversation

darnautov commented Nov 16, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Nov 16, 2020

apmmachine commented Nov 16, 2020

💚 Build Succeeded

alvarezmelissa87 Nov 16, 2020 • edited Loading

Choose a reason for hiding this comment

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 17, 2020

peteharverson left a comment

Choose a reason for hiding this comment

kibanamachine commented Nov 17, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

darnautov commented Nov 16, 2020 •

edited

Loading

alvarezmelissa87 Nov 16, 2020 •

edited

Loading