[Lens] Provide single-value functions to show the "Last" value of some field

x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.tsx

@@ -45,21 +45,22 @@ export const IndexPatternDimensionTriggerComponent = function IndexPatternDimens
 ) {
   const layerId = props.layerId;
   const layer = props.state.layers[layerId];
-  const selectedColumn: IndexPatternColumn | null = layer.columns[props.columnId] || null;
   const currentIndexPattern = props.state.indexPatterns[layer.indexPatternId];
+  const { columnId, uniqueLabel } = props;
 
-  const currentFieldIsInvalid = useMemo(
-    () => isColumnInvalid(selectedColumn, currentIndexPattern),
-    [selectedColumn, currentIndexPattern]
+  const currentColumnHasErrors = useMemo(
+    () => isColumnInvalid(layer, columnId, currentIndexPattern),
+    [layer, columnId, currentIndexPattern]
   );
 
-  const { columnId, uniqueLabel } = props;
+  const selectedColumn: IndexPatternColumn | null = layer.columns[props.columnId] || null;
+
   if (!selectedColumn) {
     return null;
   }
   const formattedLabel = wrapOnDot(uniqueLabel);
 
-  if (currentFieldIsInvalid) {
+  if (currentColumnHasErrors) {
     return (
       <EuiToolTip
         content={

x-pack/plugins/lens/public/indexpattern_datasource/operations/__mocks__/index.ts

@@ -23,7 +23,7 @@ export const {
   getOperationResultType,
   operationDefinitionMap,
   operationDefinitions,
-  fieldIsInvalid,
+  getInvalidFieldMessage,
 } = actualOperations;
 
 export const {

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/cardinality.tsx

@@ -8,7 +8,7 @@ import { i18n } from '@kbn/i18n';
 import { OperationDefinition } from './index';
 import { FormattedIndexPatternColumn, FieldBasedIndexPatternColumn } from './column_types';
 
-import { fieldIsInvalid } from '.';
+import { getInvalidFieldMessage } from './helpers';
 
 const supportedTypes = new Set(['string', 'boolean', 'number', 'ip', 'date']);
 
@@ -44,7 +44,8 @@ export const cardinalityOperation: OperationDefinition<CardinalityIndexPatternCo
       return { dataType: 'number', isBucketed: IS_BUCKETED, scale: SCALE };
     }
   },
-  hasInvalidReferences: fieldIsInvalid,
+  getErrorMessage: (layer, columnId, indexPattern) =>
+    getInvalidFieldMessage(layer.columns[columnId] as FieldBasedIndexPatternColumn, indexPattern),
   isTransferable: (column, newIndexPattern) => {
     const newField = newIndexPattern.getFieldByName(column.sourceField);
 

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/count.tsx

@@ -8,7 +8,7 @@ import { i18n } from '@kbn/i18n';
 import { OperationDefinition } from './index';
 import { FormattedIndexPatternColumn, FieldBasedIndexPatternColumn } from './column_types';
 import { IndexPatternField } from '../../types';
-import { fieldIsInvalid } from '.';
+import { getInvalidFieldMessage } from './helpers';
 
 const countLabel = i18n.translate('xpack.lens.indexPattern.countOf', {
   defaultMessage: 'Count of records',
@@ -26,7 +26,8 @@ export const countOperation: OperationDefinition<CountIndexPatternColumn, 'field
     defaultMessage: 'Count',
   }),
   input: 'field',
-  hasInvalidReferences: fieldIsInvalid,
+  getErrorMessage: (layer, columnId, indexPattern) =>
+    getInvalidFieldMessage(layer.columns[columnId] as FieldBasedIndexPatternColumn, indexPattern),
   onFieldChange: (oldColumn, field) => {
     return {
       ...oldColumn,

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/date_histogram.tsx

@@ -23,7 +23,7 @@ import { updateColumnParam } from '../layer_helpers';
 import { OperationDefinition } from './index';
 import { FieldBasedIndexPatternColumn } from './column_types';
 import { IndexPatternAggRestrictions, search } from '../../../../../../../src/plugins/data/public';
-import { fieldIsInvalid } from '.';
+import { getInvalidFieldMessage } from './helpers';
 
 const { isValidInterval } = search.aggs;
 const autoInterval = 'auto';
@@ -47,7 +47,8 @@ export const dateHistogramOperation: OperationDefinition<
   }),
   input: 'field',
   priority: 5, // Highest priority level used
-  hasInvalidReferences: fieldIsInvalid,
+  getErrorMessage: (layer, columnId, indexPattern) =>
+    getInvalidFieldMessage(layer.columns[columnId] as FieldBasedIndexPatternColumn, indexPattern),
   getPossibleOperationForField: ({ aggregationRestrictions, aggregatable, type }) => {
     if (
       type === 'date' &&

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/helpers.tsx

@@ -6,6 +6,7 @@
 
 import { useRef } from 'react';
 import useDebounce from 'react-use/lib/useDebounce';
+import { i18n } from '@kbn/i18n';
 import { operationDefinitionMap } from '.';
 import { FieldBasedIndexPatternColumn } from './column_types';
 import { IndexPattern } from '../../types';
@@ -32,12 +33,18 @@ export const useDebounceWithOptions = (
   );
 };
 
-export function fieldIsInvalid(column: FieldBasedIndexPatternColumn, indexPattern: IndexPattern) {
+export function getInvalidFieldMessage(
+  column: FieldBasedIndexPatternColumn,
+  indexPattern?: IndexPattern
+) {
+  if (!indexPattern) {
+    return;
+  }
   const { sourceField, operationType } = column;
   const field = sourceField ? indexPattern.getFieldByName(sourceField) : undefined;
   const operationDefinition = operationType && operationDefinitionMap[operationType];
 
-  return Boolean(
+  const isInvalid = Boolean(
     sourceField &&
       operationDefinition &&
       !(
@@ -46,4 +53,12 @@ export function fieldIsInvalid(column: FieldBasedIndexPatternColumn, indexPatter
         operationDefinition.getPossibleOperationForField(field) !== undefined
       )
   );
+  return isInvalid
+    ? [
+        i18n.translate('xpack.lens.indexPattern.invalidSourceField', {
+          defaultMessage: 'Field {invalidField} has an invalid reference',
+          values: { invalidField: sourceField },
+        }),
+      ]
+    : undefined;
 }

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts

@@ -175,9 +175,16 @@ interface BaseOperationDefinitionProps<C extends BaseIndexPatternColumn> {
    */
   getDisabledStatus?: (indexPattern: IndexPattern) => string | undefined;
   /**
-   * Returns true if column contains invalid references
+   * Validate that the operation has the right preconditions in the state. For example:
+   *
+   * - Requires a date histogram operation somewhere before it in order
+   * - Missing references
    */
-  hasInvalidReferences?: (column: C, indexPattern: IndexPattern) => boolean;
+  getErrorMessage?: (
+    layer: IndexPatternLayer,
+    columnId: string,
+    indexPattern?: IndexPattern
+  ) => string[] | undefined;
 }
 
 interface BaseBuildColumnArgs {
@@ -244,6 +251,17 @@ interface FieldBasedOperationDefinition<C extends BaseIndexPatternColumn> {
    * together with the agg configs returned from other columns.
    */
   toEsAggsConfig: (column: C, columnId: string, indexPattern: IndexPattern) => unknown;
+  /**
+   * Validate that the operation has the right preconditions in the state. For example:
+   *
+   * - Requires a date histogram operation somewhere before it in order
+   * - Missing references
+   */
+  getErrorMessage: (
+    layer: IndexPatternLayer,
+    columnId: string,
+    indexPattern?: IndexPattern
+  ) => string[] | undefined;
 }
 
 export interface RequiredReference {
@@ -296,13 +314,6 @@ interface FullReferenceOperationDefinition<C extends BaseIndexPatternColumn> {
     columnId: string,
     indexPattern: IndexPattern
   ) => ExpressionFunctionAST[];
-  /**
-   * Validate that the operation has the right preconditions in the state. For example:
-   *
-   * - Requires a date histogram operation somewhere before it in order
-   * - Missing references
-   */
-  getErrorMessage?: (layer: IndexPatternLayer, columnId: string) => string[] | undefined;
 }
 
 interface OperationDefinitionMap<C extends BaseIndexPatternColumn> {
@@ -359,19 +370,3 @@ export const operationDefinitionMap: Record<
   (definitionMap, definition) => ({ ...definitionMap, [definition.type]: definition }),
   {}
 );
-
-export function fieldIsInvalid(column: FieldBasedIndexPatternColumn, indexPattern: IndexPattern) {
-  const { sourceField, operationType } = column;
-  const field = sourceField ? indexPattern.getFieldByName(sourceField) : undefined;
-  const operationDefinition = operationType && operationDefinitionMap[operationType];
-
-  return Boolean(
-    sourceField &&
-      operationDefinition &&
-      !(
-        field &&
-        operationDefinition?.input === 'field' &&
-        operationDefinition.getPossibleOperationForField(field) !== undefined
-      )
-  );
-}

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.test.tsx

@@ -13,7 +13,7 @@ import { dataPluginMock } from '../../../../../../../src/plugins/data/public/moc
 import { createMockedIndexPattern } from '../../mocks';
 import { LastValueIndexPatternColumn } from './last_value';
 import { lastValueOperation } from './index';
-import { IndexPatternPrivateState, IndexPattern } from '../../types';
+import { IndexPatternPrivateState, IndexPattern, IndexPatternLayer } from '../../types';
 
 const defaultProps = {
   storage: {} as IStorageWrapper,
@@ -162,7 +162,7 @@ describe('last_value', () => {
       ).toEqual({
         dataType: 'boolean',
         isBucketed: false,
-        scale: 'ordinal',
+        scale: 'ratio',
       });
 
       expect(
@@ -176,7 +176,7 @@ describe('last_value', () => {
       ).toEqual({
         dataType: 'ip',
         isBucketed: false,
-        scale: 'ordinal',
+        scale: 'ratio',
       });
     });
 
@@ -483,47 +483,77 @@ describe('last_value', () => {
     });
   });
 
-  describe('hasInvalidReferences', () => {
+  describe('getErrorMessage', () => {
     let indexPattern: IndexPattern;
-    let column: LastValueIndexPatternColumn;
+    let layer: IndexPatternLayer;
     beforeEach(() => {
       indexPattern = createMockedIndexPattern();
-      column = {
-        dataType: 'boolean',
-        isBucketed: false,
-        label: 'Last value of test',
-        operationType: 'last_value',
-        params: { sortField: 'timestamp', sortOrder: 'desc' },
-        scale: 'ratio',
-        sourceField: 'bytes',
+      layer = {
+        columns: {
+          col1: {
+            dataType: 'boolean',
+            isBucketed: false,
+            label: 'Last value of test',
+            operationType: 'last_value',
+            params: { sortField: 'timestamp', sortOrder: 'desc' },
+            scale: 'ratio',
+            sourceField: 'bytes',
+          },
+        },
+        columnOrder: [],
+        indexPatternId: '',
       };
     });
-    it('returns false if sourceField exists and sortField is of type date ', () => {
-      expect(lastValueOperation.hasInvalidReferences!(column, indexPattern)).toEqual(false);
+    it('returns undefined if sourceField exists and sortField is of type date ', () => {
+      expect(lastValueOperation.getErrorMessage!(layer, 'col1', indexPattern)).toEqual(undefined);
     });
-    it('returns true if the sourceField does not exist in index pattern', () => {
-      expect(
-        lastValueOperation.hasInvalidReferences!(
-          { ...column, sourceField: 'notExisting' },
-          indexPattern
-        )
-      ).toEqual(true);
+    it('shows error message if the sourceField does not exist in index pattern', () => {
+      layer = {
+        ...layer,
+        columns: {
+          col1: {
+            ...layer.columns.col1,
+            sourceField: 'notExisting',
+          } as LastValueIndexPatternColumn,
+        },
+      };
+      expect(lastValueOperation.getErrorMessage!(layer, 'col1', indexPattern)).toEqual([
+        'Field notExisting has an invalid reference',
+      ]);
     });
-    it('returns true if the sortField does not exist in index pattern', () => {
-      expect(
-        lastValueOperation.hasInvalidReferences!(
-          { ...column, params: { ...column.params, sortField: 'notExisting' } },
-          indexPattern
-        )
-      ).toEqual(true);
+    it('shows error message  if the sortField does not exist in index pattern', () => {
+      layer = {
+        ...layer,
+        columns: {
+          col1: {
+            ...layer.columns.col1,
+            params: {
+              ...layer.columns.col1.params,
+              sortField: 'notExisting',
+            },
+          } as LastValueIndexPatternColumn,
+        },
+      };
+      expect(lastValueOperation.getErrorMessage!(layer, 'col1', indexPattern)).toEqual([
+        'Field notExisting has an invalid reference',
+      ]);
     });
-    it('returns true if the sortField is not date', () => {
-      expect(
-        lastValueOperation.hasInvalidReferences!(
-          { ...column, params: { ...column.params, sortField: 'bytes' } },
-          indexPattern
-        )
-      ).toEqual(true);
+    it('shows error message if the sortField is not date', () => {
+      layer = {
+        ...layer,
+        columns: {
+          col1: {
+            ...layer.columns.col1,
+            params: {
+              ...layer.columns.col1.params,
+              sortField: 'bytes',
+            },
+          } as LastValueIndexPatternColumn,
+        },
+      };
+      expect(lastValueOperation.getErrorMessage!(layer, 'col1', indexPattern)).toEqual([
+        'Field bytes has an invalid reference',
+      ]);
     });
   });
 });