Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate visualization:colorMapping advanced setting #83372

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Deprecate visualization:colorMapping advanced setting #83372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86806fa
Added deprecation for visualization:colorMapping
VladLasitsa Nov 13, 2020
ad796aa
Update text of deprecation
VladLasitsa Nov 20, 2020
24519a4
Merge remote-tracking branch 'upstream/master' into #82743
VladLasitsa Nov 20, 2020
ebea2d9
Update message
VladLasitsa Nov 20, 2020
b09d5d5
Delete from translations for re-translation
VladLasitsa Nov 20, 2020
5aac957
Merge branch 'master' into #82743
kibanamachine Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/management/advanced-options.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,7 @@ of buckets to try to represent.

[horizontal]
[[visualization-colormapping]]`visualization:colorMapping`::
**Deprecated**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more informative message like e.g.

This setting is deprecated and will no longer be supported as of 8.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flash1293 do you think this is enough or should we add more details?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I would like to add a note here about this setting only applying to Visualize charts and TSVB (not Lens). @gchaps do you have an idea how to word this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation, I'd use this wording:

This setting is deprecated and will not be supported as of 8.0. Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated text for deprecation.

Maps values to specified colors in visualizations.

[[visualization-dimmingopacity]]`visualization:dimmingOpacity`::
Expand Down
9 changes: 9 additions & 0 deletions src/plugins/charts/server/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ export class ChartsServerPlugin implements Plugin<object, object> {
description: i18n.translate('charts.advancedSettings.visualization.colorMappingText', {
defaultMessage: 'Maps values to specified colors within visualizations',
VladLasitsa marked this conversation as resolved.
Show resolved Hide resolved
}),
deprecation: {
message: i18n.translate(
'charts.advancedSettings.visualization.colorMappingTextDeprecation',
{
defaultMessage: 'This setting is deprecated.',
}
),
docLinksKey: 'visualizationSettings',
},
category: ['visualization'],
schema: schema.string(),
},
Expand Down