Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Move Elasticsearch type definitions out of APM (#83081) #83229

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Nov 11, 2020

Backports the following commits to 7.x:

...and into x-pack.

Also remove `PromiseReturnType` from APM and use the copy in observability everywhere.

All of the additional changes to APM imports are just automatic sorting.

This makes doing elastic#77720 a little easier and removes some implicit circular dependencies for elastic#80508.

Co-authored-by: Dario Gieselaar <[email protected]>
# Conflicts:
#	x-pack/plugins/apm/public/utils/testHelpers.tsx
@smith smith added the backport label Nov 11, 2020
@smith
Copy link
Contributor Author

smith commented Nov 12, 2020

@elasticmachine run the e2e

@smith
Copy link
Contributor Author

smith commented Nov 12, 2020

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 43130 43128 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit fabfc54 into elastic:7.x Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants