[Maps] saved object tagging #83197

nreese · 2020-11-11T18:15:05Z

Closes #82434

This PR adds saved object tagging to listing page and save modal

elasticmachine · 2020-11-11T18:15:07Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2020-11-11T20:02:01Z

@elasticmachine merge upstream

pgayvallet

That's great to see tagging implemented in another app!

Some comments:

Could you update your feature to add the `tag` SO read permission. Else a user would not be able to properly use tags when he's only granted permissions to see `map`

kibana/x-pack/plugins/maps/server/plugin.ts

Lines 173 to 177 in e909cee

    
           features.registerKibanaFeature({ 
        
             id: APP_ID, 
        
             name: i18n.translate('xpack.maps.featureRegistry.mapsFeatureName', { 
        
               defaultMessage: 'Maps', 
        
             }),

See

kibana/x-pack/plugins/features/server/oss_features.ts

Lines 89 to 91 in d4b2a51

    
           savedObject: { 
        
             all: ['visualization', 'query', 'lens'], 
        
             read: ['index-pattern', 'search', 'tag'],

Could you update the RBAC integration tests to add a new `map` user

See

kibana/x-pack/test/saved_object_tagging/api_integration/security_and_spaces/apis/create.ts

Lines 60 to 61 in d4b2a51

    
           USERS.DEFAULT_SPACE_DASHBOARD_READ_USER, 
        
           USERS.DEFAULT_SPACE_VISUALIZE_READ_USER,

and

kibana/x-pack/test/saved_object_tagging/common/lib/authentication.ts

Lines 178 to 182 in d4b2a51

    
           DEFAULT_SPACE_VISUALIZE_READ_USER: { 
        
             username: 'a_kibana_rbac_default_space_visualize_read_user', 
        
             password: 'password', 
        
             roles: [ROLES.KIBANA_RBAC_DEFAULT_SPACE_VISUALIZE_READ_USER.name], 
        
           },

(Optional) Could you add a FTR test for tag integration within map

As it is done for dash and vis in x-pack/test/saved_object_tagging/functional/tests/dashboard_integration.ts and x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts

alexfrancoeur · 2020-11-12T16:43:57Z

🥳

lukeelmers

app arch code changes LGTM

nreese · 2020-11-12T19:22:34Z

@pgayvallet

Could you update your feature to add the tag SO read permission. Else a user would not be able to properly use tags when he's only granted permissions to see map

Add tag to features registration

Could you update the RBAC integration tests to add a new map user

Added RBAC integration test for map read only user

Could you add a FTR test for tag integration within map

Added functional test for maps integration testing listing, create, and edit

pgayvallet

LGTM once these two points are addressed

x-pack/plugins/maps/server/plugin.ts

x-pack/test/saved_object_tagging/api_integration/security_and_spaces/apis/create.ts

…t_all, and update tests

nreese · 2020-11-12T21:43:49Z

@elasticmachine merge upstream

nreese · 2020-11-16T15:17:29Z

@elasticmachine merge upstream

thomasneirynck

lgtm!

x-pack/plugins/maps/public/routes/list_page/maps_list_view.tsx

nreese · 2020-11-16T23:35:22Z

@elasticmachine merge upstream

kibanamachine · 2020-11-17T01:12:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 249f4dc

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	2.8MB	2.8MB	-5.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaReact`	131.9KB	131.9KB	+38.0B
`maps`	150.7KB	150.9KB	+157.0B
total			+195.0B

History

💚 Build #88023 succeeded 8a19a47
💚 Build #87753 succeeded f83003f
💛 Build #87723 was flaky 636433d
💚 Build #87711 succeeded 22c5e8f
💚 Build #87527 succeeded a6e6ae5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* add tag selector to save modal * save tag references onSave * populate tags when unwrapping attributes * tslint * update listing page to show tags * fix data-test-subj id in functional tests * i18n cleanup * tslint * remove unused import * use listingTable service for functional tests * tslint and fix mvt grid layer functional test * review feedback * add tags to all privileges and add test user to find, delete, get, get_all, and update tests * move functions to module scope Co-authored-by: Kibana Machine <[email protected]>

* [Maps] saved object tagging (#83197) * add tag selector to save modal * save tag references onSave * populate tags when unwrapping attributes * tslint * update listing page to show tags * fix data-test-subj id in functional tests * i18n cleanup * tslint * remove unused import * use listingTable service for functional tests * tslint and fix mvt grid layer functional test * review feedback * add tags to all privileges and add test user to find, delete, get, get_all, and update tests * move functions to module scope Co-authored-by: Kibana Machine <[email protected]> * mappings.json * add map saved object mapping Co-authored-by: Kibana Machine <[email protected]>

nreese added 5 commits November 10, 2020 14:45

add tag selector to save modal

52dfd2a

save tag references onSave

34f6385

populate tags when unwrapping attributes

f506746

tslint

4038418

update listing page to show tags

ebc47e7

nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.11.0 labels Nov 11, 2020

nreese requested a review from thomasneirynck November 11, 2020 18:15

nreese added 2 commits November 11, 2020 11:19

fix data-test-subj id in functional tests

acbf255

i18n cleanup

447876e

kibanamachine and others added 3 commits November 11, 2020 15:02

Merge branch 'master' into tags

18be280

tslint

b8fc068

remove unused import

2cb1ea5

nreese mentioned this pull request Nov 11, 2020

Add saved object tags to integrations with Kibana saved objects elastic/integrations#327

Closed

nreese added 2 commits November 11, 2020 16:17

use listingTable service for functional tests

a189307

tslint and fix mvt grid layer functional test

a6e6ae5

nreese requested review from a team as code owners November 12, 2020 01:40

pgayvallet reviewed Nov 12, 2020

View reviewed changes

pgayvallet added the Feature:Saved Object Tagging Saved Objects Tagging feature label Nov 12, 2020

lukeelmers approved these changes Nov 12, 2020

View reviewed changes

review feedback

22c5e8f

nreese requested a review from a team as a code owner November 12, 2020 19:20

nreese requested a review from pgayvallet November 12, 2020 19:23

pgayvallet approved these changes Nov 12, 2020

View reviewed changes

x-pack/plugins/maps/server/plugin.ts Show resolved Hide resolved

x-pack/test/saved_object_tagging/api_integration/security_and_spaces/apis/create.ts Show resolved Hide resolved

add tags to all privileges and add test user to find, delete, get, ge…

636433d

…t_all, and update tests

Merge branch 'master' into tags

f83003f

Merge branch 'master' into tags

8a19a47

thomasneirynck approved these changes Nov 16, 2020

View reviewed changes

x-pack/plugins/maps/public/routes/list_page/maps_list_view.tsx Outdated Show resolved Hide resolved

move functions to module scope

37daf1a

Merge branch 'master' into tags

249f4dc

nreese merged commit a2c91f1 into elastic:master Nov 17, 2020

nreese mentioned this pull request Nov 17, 2020

[7.x] [Maps] saved object tagging (#83197) #83509

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] saved object tagging #83197

[Maps] saved object tagging #83197

nreese commented Nov 11, 2020

elasticmachine commented Nov 11, 2020

nreese commented Nov 11, 2020

pgayvallet left a comment

alexfrancoeur commented Nov 12, 2020

lukeelmers left a comment

nreese commented Nov 12, 2020

pgayvallet left a comment

nreese commented Nov 12, 2020

nreese commented Nov 16, 2020

thomasneirynck left a comment

nreese commented Nov 16, 2020

kibanamachine commented Nov 17, 2020

	features.registerKibanaFeature({
	id: APP_ID,
	name: i18n.translate('xpack.maps.featureRegistry.mapsFeatureName', {
	defaultMessage: 'Maps',
	}),

	savedObject: {
	all: ['visualization', 'query', 'lens'],
	read: ['index-pattern', 'search', 'tag'],

	USERS.DEFAULT_SPACE_DASHBOARD_READ_USER,
	USERS.DEFAULT_SPACE_VISUALIZE_READ_USER,

	DEFAULT_SPACE_VISUALIZE_READ_USER: {
	username: 'a_kibana_rbac_default_space_visualize_read_user',
	password: 'password',
	roles: [ROLES.KIBANA_RBAC_DEFAULT_SPACE_VISUALIZE_READ_USER.name],
	},

[Maps] saved object tagging #83197

[Maps] saved object tagging #83197

Conversation

nreese commented Nov 11, 2020

elasticmachine commented Nov 11, 2020

nreese commented Nov 11, 2020

pgayvallet left a comment

Choose a reason for hiding this comment

Could you update your feature to add the tag SO read permission. Else a user would not be able to properly use tags when he's only granted permissions to see map

Could you update the RBAC integration tests to add a new map user

(Optional) Could you add a FTR test for tag integration within map

alexfrancoeur commented Nov 12, 2020

lukeelmers left a comment

Choose a reason for hiding this comment

nreese commented Nov 12, 2020

pgayvallet left a comment

Choose a reason for hiding this comment

nreese commented Nov 12, 2020

nreese commented Nov 16, 2020

thomasneirynck left a comment

Choose a reason for hiding this comment

nreese commented Nov 16, 2020

kibanamachine commented Nov 17, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Could you update your feature to add the `tag` SO read permission. Else a user would not be able to properly use tags when he's only granted permissions to see `map`

Could you update the RBAC integration tests to add a new `map` user