Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Workplace Search] Refactor nav constants (#82646) #82999

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

scottybollinger
Copy link
Contributor

Backports the following commits to 7.x:

* Move NAV constants to top level

This was only needed locally in Groups but we can to store all  nav constants in the global constants file

* Extract remaining nav constants

* Fix links to NAV in routers

* Use constant for path

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 450 449 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 666.5KB 666.7KB +174.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 5e7d721 into elastic:7.x Nov 9, 2020
@scottybollinger scottybollinger deleted the backport/7.x/pr-82646 branch November 9, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants