Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Remove kui usage #82810

Merged
merged 5 commits into from
Nov 10, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 6, 2020

Summary

Closes #82711. I removed the kui usage from https://github.com/elastic/kibana/blob/master/src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx. I actually replaced the previous message with a EuiCallout EuiEmptyPrompt.

Before:
Screenshot 2020-11-06 at 11 43 13 AM

Now:
Screenshot 2020-11-09 at 12 12 51 PM

Checklist

Delete any items that are not applicable to this PR.

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
@stratoula stratoula changed the title [Visualize] Remove kui usage [Visualizations] Remove kui usage Nov 6, 2020
@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v7.11.0 v8.0.0 labels Nov 6, 2020
@stratoula stratoula marked this pull request as ready for review November 6, 2020 12:05
@stratoula stratoula requested a review from a team November 6, 2020 12:05
@stratoula stratoula requested a review from a team as a code owner November 6, 2020 12:05
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments for your review. Thanks!

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula requested a review from a team as a code owner November 9, 2020 14:49
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those earlier comments. This looks great. I left two super small nitpick comments for your review, but otherwise, this LGTM. Approving now so I don't hold you up any further.

className="kuiVerticalRhythm visDisabledLabVisualization__icon kuiIcon fa-flask"
aria-hidden="true"
<I18nProvider>
<EuiEmptyPrompt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we add a titleSize="xs" prop to EuiEmptyPrompt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed them both! Thank you 🙂
Screenshot 2020-11-09 at 5 47 44 PM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
visualizations 56.7KB 56.7KB -1.0B

distributable file count

id before after diff
default 42763 42762 -1
oss 22452 22451 -1

page load bundle size

id before after diff
core 547.1KB 547.3KB +152.0B
visualizations 170.4KB 169.7KB -703.0B
total -551.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra
Copy link
Contributor

Checked both for dashboard and the visualization itself - both work great. Nice improvement!!!

@stratoula stratoula merged commit 471c281 into elastic:master Nov 10, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Nov 10, 2020
* [Visualize] Remove kui usage

* Use EuiPromptButton istead of EuiCallout

* Add a link to advanced settings for visualizations docs

* Changes requested on code review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula added a commit that referenced this pull request Nov 10, 2020
* [Visualize] Remove kui usage

* Use EuiPromptButton istead of EuiCallout

* Add a link to advanced settings for visualizations docs

* Changes requested on code review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 10, 2020
…kibana into bootstrap-node-details-overlay

* 'bootstrap-node-details-overlay' of github.com:phillipb/kibana: (49 commits)
  [Security Solution] Fix DNS Network table query (elastic#82778)
  [Workplace Search] Consolidate groups routes (elastic#83015)
  Adds cloud links to user menu (elastic#82803)
  [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023)
  [App Search] Added the log retention panel to the Settings page (elastic#82982)
  [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006)
  [DOCS] Consolidates drilldown pages (elastic#82081)
  [Maps] add on-prem EMS config (elastic#82525)
  migrate i18n mixin to KP (elastic#81799)
  [bundle optimization] fix imports of react-use lib (elastic#82847)
  [Discover] Add metric on adding filter (elastic#82961)
  [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829)
  skip flaky suite (elastic#82804)
  Fix SO query for searching across spaces (elastic#83025)
  renaming built-in alerts to Stack Alerts (elastic#82873)
  [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278)
  [Visualizations] Remove kui usage (elastic#82810)
  [Visualizations] Make the icon buttons labels more descriptive (elastic#82585)
  [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694)
  Fix ilm navigation (elastic#81664)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 10, 2020
…na into alerts/stack-alerts-public

* 'alerts/stack-alerts-public' of github.com:gmmorris/kibana:
  [Security Solution] Fix DNS Network table query (elastic#82778)
  [Workplace Search] Consolidate groups routes (elastic#83015)
  Adds cloud links to user menu (elastic#82803)
  [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023)
  [App Search] Added the log retention panel to the Settings page (elastic#82982)
  [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006)
  [DOCS] Consolidates drilldown pages (elastic#82081)
  [Maps] add on-prem EMS config (elastic#82525)
  migrate i18n mixin to KP (elastic#81799)
  [bundle optimization] fix imports of react-use lib (elastic#82847)
  [Discover] Add metric on adding filter (elastic#82961)
  [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829)
  skip flaky suite (elastic#82804)
  Fix SO query for searching across spaces (elastic#83025)
  renaming built-in alerts to Stack Alerts (elastic#82873)
  [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278)
  [Visualizations] Remove kui usage (elastic#82810)
  [Visualizations] Make the icon buttons labels more descriptive (elastic#82585)
  [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694)
:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove KUI traces from Visualizations code
7 participants