Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix Overview cypress tests #82761

Merged
merged 1 commit into from
Nov 5, 2020
Merged

[Security Solution] Fix Overview cypress tests #82761

merged 1 commit into from
Nov 5, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Nov 5, 2020 •
edited
Loading

Summary

We have removed id from Search Strategy, so we need to adjust Cypress tests to mock requests properly
#82650

Fixes #81848

@patrykkopycinski patrykkopycinski added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 5, 2020
@patrykkopycinski patrykkopycinski requested review from a team as code owners November 5, 2020 18:22
@patrykkopycinski patrykkopycinski self-assigned this Nov 5, 2020
@jbudz
Copy link
Member

jbudz commented Nov 5, 2020

I'm merging early due to the previous red build, will be monitoring

@jbudz jbudz merged commit 9bff56d into elastic:master Nov 5, 2020
jbudz pushed a commit that referenced this pull request Nov 5, 2020
@patrykkopycinski @jbudz
[Security Solution] Fix Overview cypress tests (#82761)
dbc274b
@jbudz
Copy link
Member

jbudz commented Nov 5, 2020 •
edited
Loading

7.x: dbc274b

@XavierM
Copy link
Contributor

XavierM commented Nov 5, 2020

I'm merging early due to the previous red build, will be monitoring

Thank you!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 82761 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 82761 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 82761 or prevent reminders by adding the backport:skip label.

@patrykkopycinski patrykkopycinski deleted the fix/overview-cypress-test branch November 11, 2020 19:18
@patrykkopycinski patrykkopycinski added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

@XavierM XavierM XavierM approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@patrykkopycinski @jbudz @XavierM @kibanamachine @angorayc