Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Remove asterix from test file name #82721

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Nov 5, 2020

Summary

This was causing an issue on Windows machines. Reverted the original commit out of master.

This PR unreverts that commit and renames the file to remove the asterix.

@crob611 crob611 requested a review from a team November 5, 2020 14:43
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@crob611 crob611 added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ingestManager 1.2MB 1.2MB -4.0B

page load bundle size

id before after diff
ingestManager 385.8KB 386.4KB +609.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Nov 5, 2020

@jfsiii Can I get an approval on this one. Had to revert the one from yesterday due to a filename causing issues on Windows. This is just an unrevert and rename file. Thanks,

@jfsiii jfsiii merged commit 6437139 into elastic:master Nov 5, 2020
crob611 pushed a commit to crob611/kibana that referenced this pull request Nov 6, 2020
* Revert "Revert "[Fleet] Allow snake cased Kibana assets (elastic#77515)" (elastic#82706)"

This reverts commit bc05e79.

* Rename test index pattern
crob611 pushed a commit that referenced this pull request Nov 9, 2020
* Revert "Revert "[Fleet] Allow snake cased Kibana assets (#77515)" (#82706)"

This reverts commit bc05e79.

* Rename test index pattern

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants