-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Move notifyOnError to fix in-progress alerts for ciGroups #82506
Merged
brianseeders
merged 1 commit into
elastic:master
from
brianseeders:fix-in-progress-alerts
Nov 4, 2020
Merged
[CI] Move notifyOnError to fix in-progress alerts for ciGroups #82506
brianseeders
merged 1 commit into
elastic:master
from
brianseeders:fix-in-progress-alerts
Nov 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
Team:Operations
Team label for Operations Team
v8.0.0
Feature:CI
Continuous integration
v7.11.0
v7.10.1
v7.9.4
labels
Nov 3, 2020
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spalger
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Nov 3, 2020
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
This was referenced Nov 4, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Nov 4, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Nov 4, 2020
brianseeders
added a commit
that referenced
this pull request
Nov 4, 2020
brianseeders
added a commit
that referenced
this pull request
Nov 4, 2020
brianseeders
added a commit
that referenced
this pull request
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:CI
Continuous integration
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.9.4
v7.10.1
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notifyOnError{}
is not currently wrapping ciGroup task executions, so in-progress notifications (GitHub and Slack) are not working. Thanks to @spalger for noticing and letting me know.