[Lens] Fix console error by passing I18nProvider to metric vis #82282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
requested changes
Nov 2, 2020
| @@ -93,7 +93,9 @@ export const getMetricChartRenderer = ( | |||
| ) => { | |||
| const resolvedFormatFactory = await formatFactory; | |||
| ReactDOM.render( | |||
| <MetricChart {...config} formatFactory={resolvedFormatFactory} />, | |||
| <I18nProvider> | |||
| <MetricChart {...config} formatFactory={resolvedFormatFactory} />, | |||
There was a problem hiding this comment.
I'm still getting an error in the console, but a different one:
It seems to be caused by the trailing comma in line 97 here - looks like it can be removed
flash1293
approved these changes
Nov 2, 2020
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Nov 2, 2020
…ic#82282) * [Lens] Fix console error by passing I18nProvider to metric vis * Update expression.tsx
mbondyra
added a commit
that referenced
this pull request
Nov 3, 2020
… (#82337) * [Lens] Fix console error by passing I18nProvider to metric vis * Update expression.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes this console error:
