Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable send to background in Timelion #82232

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 1, 2020

Summary

To enable send to background query in Timelion we should pass sessionId into data.search method. This PR adds this logic

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
visTypeTimelion 34.3KB 34.8KB +561.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp requested review from lizozom and stratoula November 2, 2020 07:44
@alexwizp alexwizp self-assigned this Nov 2, 2020
@alexwizp alexwizp added v7.11.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Timelion Timelion app and visualization labels Nov 2, 2020
@alexwizp alexwizp marked this pull request as ready for review November 2, 2020 08:45
@alexwizp alexwizp requested a review from a team November 2, 2020 08:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested it locally in Chrome

@alexwizp alexwizp merged commit 085f65d into elastic:master Nov 2, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Nov 2, 2020
* Enable send to background in Timelion

* add jest
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 2, 2020
…e-details-overlay

* 'master' of github.com:elastic/kibana: (72 commits)
  [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487)
  [APM] Scale transaction rate correctly (elastic#82155)
  Upgrade to hapi version 18 (elastic#80468)
  [Uptime] Remove custom handling of license enabling (elastic#82019)
  [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579)
  Enable send to background in Vega (elastic#82229)
  Enable send to background in Timelion (elastic#82232)
  [Actions & Connectors] removes Connector flyouts after usage (elastic#82126)
  Add derivative function (elastic#81178)
  [Discover] Deangularize context_app.html, part 3 (elastic#81838)
  [Visualize] Vis listing page breaks on unknown vis type (elastic#82018)
  Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123)
  Minor edits in Single Metric Viewer (elastic#82159)
  [Actions] Fix type contract (elastic#82168)
  Upgrade EUI to v30.1.1 (elastic#81499)
  Skip failing ES snapshot test (elastic#82207)
  Skip ES snapshot failing suite (elastic#82206)
  [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876)
  [Maps] convert vector style component to typescript round 1 (elastic#81961)
  Fix link to upgrade assistant (elastic#82138)
  ...
alexwizp added a commit that referenced this pull request Nov 2, 2020
* Enable send to background in Timelion

* add jest
@alexwizp alexwizp deleted the backgroung_timelion branch January 16, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants