Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deb/rpm] Remove /var prefix from tmpfiles.d #82196

Merged
merged 7 commits into from
Nov 9, 2020
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 30, 2020

We currently include a tmpfiles.d used to create a folder for writing
the pid. This is set to /var/run/kibana and newer distributions
consider this a legacy path. This is symlinked in
supported systems to /run.

Example from Fedora 33:

/usr/lib/tmpfiles.d/kibana.conf:1: Line references path below legacy
directory /var/run/, updating /var/r
un/kibana → /run/kibana; please update the tmpfiles.d/ drop-in file
accordingly.

We currently include a tmpfiles.d used to create a folder for writing
the pid.  This is set to /var/run/kibana and newer distributions
consider this a legacy path.  This is symlinked in
supported systems to /run.

Example from Fedora 33:
/usr/lib/tmpfiles.d/kibana.conf:1: Line references path below legacy
directory /var/run/, updating /var/r
un/kibana → /run/kibana; please update the tmpfiles.d/ drop-in file
accordingly.
@jbudz jbudz added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 30, 2020
@jbudz jbudz requested a review from a team as a code owner October 30, 2020 20:29
@jbudz
Copy link
Member Author

jbudz commented Oct 30, 2020

jon@debd1:~/kibana$ cat /usr/lib/tmpfiles.d/kibana.conf
d    /run/kibana  07ls -lah /run/kibana/
total 0
drwxr-xr-x  2 kibana kibana   40 Oct 29 16:52 .
drwxr-xr-x 31 root   root   1000 Oct 30 16:09 ..

https://s3-us-west-1.amazonaws.com/kibana.budzenski.com/82196/d455684/kibana-8.0.0-SNAPSHOT-x86_64.rpm
https://s3-us-west-1.amazonaws.com/kibana.budzenski.com/82196/d455684/kibana-8.0.0-SNAPSHOT-amd64.deb

@jbudz
Copy link
Member Author

jbudz commented Nov 2, 2020

@elasticmachine merge upstream

@jbudz jbudz added the review label Nov 2, 2020
@jbudz
Copy link
Member Author

jbudz commented Nov 4, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Nov 6, 2020

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

Will be good to not see this warning anymore.

Should we update the existing references to /var/run/kibana including in our config?

@jbudz jbudz requested a review from a team as a code owner November 9, 2020 13:55
@jbudz
Copy link
Member Author

jbudz commented Nov 9, 2020

Pushed the kibana.yml change with 975bb12

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit b5e6d7c into elastic:master Nov 9, 2020
@jbudz jbudz deleted the os/rm-var-pid branch November 9, 2020 16:05
jbudz added a commit that referenced this pull request Nov 9, 2020
@jbudz
Copy link
Member Author

jbudz commented Nov 9, 2020

7.x/7.11: ed10f3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants