[lens] fix unhandled promise rejection when saving Lens with duplicate title #82195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
chore
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
nreese
commented
Oct 30, 2020
| @@ -359,7 +359,6 @@ export function App({ | |||
| const docToSave = { | |||
| ...getLastKnownDocWithoutPinnedFilters()!, | |||
| description: saveProps.newDescription, | |||
| savedObjectId: saveProps.newCopyOnSave ? undefined : lastKnownDoc.savedObjectId, | |||
There was a problem hiding this comment.
Removed savedObjectId from docToSave because it is not used and made tracking down how attributeService.wrapAttributes pulls out the savedObjectId extra tricky
nreese
commented
Oct 30, 2020
| @@ -453,11 +457,6 @@ export function App({ | |||
| // eslint-disable-next-line no-console | |||
| console.dir(e); | |||
| trackUiEvent('save_failed'); | |||
| notifications.toasts.addDanger( | |||
There was a problem hiding this comment.
Remove toast notification on save failure. Toast is already displayed by AttributeService.wrapAttributes
nreese
commented
Oct 30, 2020
| @@ -375,25 +374,31 @@ export function App({ | |||
|
|
|||
| const originalInput = saveProps.newCopyOnSave ? undefined : initialInput; | |||
| const originalSavedObjectId = (originalInput as LensByReferenceInput)?.savedObjectId; | |||
| if (options.saveToLibrary && !originalInput) { | |||
There was a problem hiding this comment.
Removed && !originalInput because this actually caused a title naming conflict without warning users.
Steps to view:
- create and save a lens saved object called "alpha"
- create and save another lens saved object called "bravo"
- edit the first lens saved object. Click save and change the title to "bravo". Click save. The modal should notify user about duplicate title but it does not.
ThomThomson
approved these changes
Oct 30, 2020
|
@elasticmachine merge upstream |
flash1293
approved these changes
Nov 2, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 2, 2020
…e title (elastic#82195) * [lens] fix unhandled promise rejection when saving Lens with duplicate title * more clean up * restore getDisplayName, used by return of checkForDuplicateTitle * fix jest test Co-authored-by: Kibana Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Nov 2, 2020
…e title (#82195) (#82342) * [lens] fix unhandled promise rejection when saving Lens with duplicate title * more clean up * restore getDisplayName, used by return of checkForDuplicateTitle * fix jest test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #82173
PR adds try/catch around checkForDuplicateTitle to handle rejection when there is a duplicate title