Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] add force flag to upgrade agents api #82178

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

neptunian
Copy link
Contributor

Resolves #81845

  • Adds a force option to /agents/{agentId}/upgrade and /agents/bulk_upgrade endpoints that bypasses the restriction that you must upgrade the agent to a higher version that the currently installed agent. This can be used for testing when versions are the same but are different builds, so someone can upgrade a version to the same version.
  • Adds a missing test to cover when attempting to bulk upgrade agents to a version that does not match the installed kibana version

@neptunian neptunian added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 30, 2020
@neptunian neptunian requested a review from a team October 30, 2020 18:11
@neptunian neptunian self-assigned this Oct 30, 2020
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@neptunian neptunian force-pushed the 81845-force-flag-upgrade-agent branch from cf04492 to e0642fe Compare November 2, 2020 16:27
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #85156 failed cf044926b5bcff4bf6df0c61e1f16362198049c5
  • 💔 Build #84920 failed 379a1bc9848ceb2f932fb81bf31b640f7e114142

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian merged commit f2bf8c9 into elastic:master Nov 2, 2020
@neptunian neptunian deleted the 81845-force-flag-upgrade-agent branch November 2, 2020 18:11
neptunian added a commit to neptunian/kibana that referenced this pull request Nov 2, 2020
* add force flag to upgrade agents api

* use 1.0.0 as version that wont match to see if test passes
neptunian added a commit that referenced this pull request Nov 2, 2020
* add force flag to upgrade agents api

* use 1.0.0 as version that wont match to see if test passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Have a force option for upgrading agents API
4 participants