Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/codeowners #82146

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Cleanup/codeowners #82146

merged 3 commits into from
Oct 30, 2020

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Oct 30, 2020

Summary

This file adds our missing READMEs. It also removed redundant CC lines from CODEOWNERS (since we already have them under our regular CODEOWNERSHIP the additional CC line is not needed), also it moves the index pattern management plugin completely to App Arch (as we decided recently).

@timroes timroes added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 30, 2020
@timroes timroes requested a review from a team October 30, 2020 15:09
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small typo. Also I guess we should add the index pattern management plugin to the app arch list outside of the coverage mapping

@@ -0,0 +1,5 @@
# Managament Plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "Management"

@timroes
Copy link
Contributor Author

timroes commented Oct 30, 2020

@flash1293 Thanks for catching the typo. The index pattern management section didn't had any codeowner outside CC yet, I wanted to leave that decicions to App Arch if they want to set it up to their list.

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in that case, I will let the app arch team know

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

distributable file count

id before after diff
default 48140 48142 +2
oss 28623 28625 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes merged commit d8eb414 into elastic:master Oct 30, 2020
@timroes timroes deleted the cleanup/codeowners branch October 30, 2020 17:30
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 2, 2020
* master:
  Add derivative function (elastic#81178)
  [Discover] Deangularize context_app.html, part 3 (elastic#81838)
  [Visualize] Vis listing page breaks on unknown vis type (elastic#82018)
  Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123)
  Minor edits in Single Metric Viewer (elastic#82159)
  [Actions] Fix type contract (elastic#82168)
  Upgrade EUI to v30.1.1 (elastic#81499)
  Skip failing ES snapshot test (elastic#82207)
  Skip ES snapshot failing suite (elastic#82206)
  [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876)
  [Maps] convert vector style component to typescript round 1 (elastic#81961)
  Fix link to upgrade assistant (elastic#82138)
  Rename "service overview" to "service inventory" (elastic#81933)
  adjust policy test to drop test for server addresses (elastic#82120)
  Cleanup/codeowners (elastic#82146)
  [DOCS] Updates add data content (elastic#81093)
  [DOCS] Remove index mgmt docs (elastic#82099)
  [Search] fix cancelation related memory leaks (elastic#81996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants