Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Context menu trigger for URL Drilldown (#81158) #82119

Merged
merged 1 commit into from
Oct 30, 2020
Merged

[7.x] Context menu trigger for URL Drilldown (#81158) #82119

merged 1 commit into from
Oct 30, 2020

Conversation

streamich
Copy link
Contributor

Backports the following commits to 7.x:

* feat: 🎸 add context menu trigger to URL drilldown

* fix: 🐛 translate "Drilldowns" grouping title

* feat: 🎸 add dynamic action grouping to dynamic actions

* fix: 🐛 add translations to trigger texts

* feat: 🎸 enambe ctx menu trigger in both flyouts, move to end

* fix: 🐛 show context menu event scope variable sfor ctx menu

* test: 💍 add tests

* fix: 🐛 use correct namespace for translation keys

* docs: ✏️ update autogenerated docs

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
uiActionsEnhanced 139 140 +1

page load bundle size

id before after diff
dashboardEnhanced 31.1KB 31.1KB +52.0B
embeddable 184.3KB 186.3KB +2.0KB
embeddableEnhanced 18.9KB 19.0KB +73.0B
uiActionsEnhanced 304.7KB 304.6KB -135.0B
urlDrilldown 13.7KB 13.9KB +194.0B
total +2.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 3f5577f into elastic:7.x Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants