Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move task manager README.md to root of plugin #82012

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Move task manager README.md to root of plugin #82012

merged 2 commits into from
Oct 29, 2020

Conversation

mikecote
Copy link
Contributor

In this PR, I'm moving the README.md of task manager from /server to the plugin's root. This will make all the alerting team's plugins have a README.md file on the root explaining the plugin.

@mikecote mikecote added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 labels Oct 29, 2020
@mikecote mikecote self-assigned this Oct 29, 2020
@mikecote mikecote marked this pull request as ready for review October 29, 2020 14:17
@mikecote mikecote requested a review from a team as a code owner October 29, 2020 14:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1
ymao1 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote requested a review from ymao1 October 29, 2020 14:54
@mikecote
Copy link
Contributor Author

Thanks for the quick review @ymao1. It looks like there was one place that CI wanted me to update so I went ahead and changed a few things. Let me know if it still LGTY!

gmmorris
gmmorris approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit 84b23b6 into elastic:master Oct 29, 2020
@mikecote mikecote mentioned this pull request Oct 29, 2020
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request Oct 29, 2020
@mikecote
Move task manager README.md to root of plugin (elastic#82012)
0d40daf 
* Move task manager README.md to root of plugin

* Fix failing test, update task manager plugin description in docs
mikecote added a commit that referenced this pull request Oct 29, 2020
@mikecote
Move task manager README.md to root of plugin (#82012) (#82048)
96bcedf 
* Move task manager README.md to root of plugin

* Fix failing test, update task manager plugin description in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@gmmorris gmmorris gmmorris approved these changes

Assignees

@mikecote mikecote

Labels
Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikecote @elasticmachine @kibanamachine @gmmorris @ymao1