Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Fix misleading copy and fix serialization #81908

Merged
merged 1 commit into from
Oct 29, 2020
Merged

[ILM] Fix misleading copy and fix serialization #81908

merged 1 commit into from
Oct 29, 2020

Conversation

jloleysens
Copy link
Contributor

Fix misleading copy and fix serialization of custom without node attribute.

Summary

Backport of 28dffcf which is a fix for #81697
Backport of 7fff5a8 which is a fix for #81648

Screenshot of updated copy

Screenshot 2020-10-27 at 16 41 29

Checklist

@jloleysens jloleysens added backport release_note:skip Skip the PR/issue when compiling release notes v7.10.1 labels Oct 28, 2020
@jloleysens jloleysens requested a review from cjcenizal October 28, 2020 14:58
@jloleysens jloleysens added release_note:fix release_note:skip Skip the PR/issue when compiling release notes and removed release_note:skip Skip the PR/issue when compiling release notes release_note:fix labels Oct 28, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
indexLifecycleManagement 236.2KB 236.1KB -62.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal
cjcenizal approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy changes LGTM! Didn't test locally or review backported code.

@jloleysens jloleysens merged commit 04a19e3 into elastic:7.10 Oct 29, 2020
@jloleysens jloleysens deleted the ilm/fix-copy-and-serialization branch October 29, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
backport release_note:skip Skip the PR/issue when compiling release notes v7.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jloleysens @kibanamachine @cjcenizal