[Task Manager] Fixing flaky test #81901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
Feature:Task Manager
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Oct 28, 2020
ymao1
added a commit
that referenced
this pull request
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #81853
Summary
Fixing flaky task manager test. Was testing that a recurring task would continue being claimed even after
maxAttemptswas exceeded and trying to match the number of attempts to exactly maxAttempts + 1. If the retry loop missed that exact number and the number attempts exceededmaxAttempts+ 1, the test would keep retrying. Updated test to just check that number of attempts has exceededmaxAttemptsRan through the flaky test runner 100 times. Results here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/916/ specifically this test suite