Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add uri decode to es_ui_shared and fix navigation issues with special characters (#80835) #81897

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

yuliacech
Copy link
Contributor

Backports the following commits to 7.x:

… characters (elastic#80835)

* Add uri decode to es_ui_shared and fix data stream issue with % name

* Add a test for data streams tab opened for name with a dollar sign

* Import uri decode function from es_ui_shared and fix navigation issues for filters

* Add tests for data streams with special characters in name

* Revert react router navigate changes (is done in a separate PR)

* Reverting changes to dataManagement es client and get data stream api route

* Fix data stream name filter when activated from a url parameter

* Clean up for better consistency and fixes after
elastic#81664

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
esUiShared 207 208 +1
indexManagement 510 509 -1
ingestPipelines 493 491 -2
total -2

async chunks size

id before after diff
indexLifecycleManagement 312.4KB 312.4KB +5.0B
indexManagement 1.1MB 1.1MB -324.0B
ingestPipelines 814.5KB 814.3KB -136.0B
total -455.0B

page load bundle size

id before after diff
esUiShared 303.4KB 303.6KB +241.0B
indexManagement 643.2KB 642.8KB -356.0B
ingestPipelines 41.9KB 42.0KB +153.0B
total +38.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech merged commit e22f2b4 into elastic:7.x Oct 28, 2020
@yuliacech yuliacech deleted the backport/7.x/pr-80835 branch December 3, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants