Converting vislib to use ES6 syntax #8186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM, tests are passing and the functionality here hasn't changed at all |
|
Could we put the commit that converts functions to classes in a separate PR? There are some unresolved arguments about whether we should even recommend classes in our styleguide, so I'd like to resolve those before we start converting everything to |
|
This change is only a small part of the much larger #8174. In that pr, several new1 classes are being defined to replace the classes seen here. In my eyes, that means these changes are helping to build a comprehensible progression to the final, not a refactor or starting the "converting everything to 1: It's pretty obvious that we are fine with new development using |
This was referenced Sep 22, 2016
ppisljar
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** converting to ES6 class syntax * Original sha: 161ba75 * Authored by ppisljar <[email protected]> on 2016-09-08T14:28:44Z **Commit 2:** let to const * Original sha: 9cb6b60 * Authored by ppisljar <[email protected]> on 2016-09-08T14:54:41Z **Commit 3:** fixing indentation to match our style * Original sha: 0b63b83 * Authored by ppisljar <[email protected]> on 2016-09-08T15:08:56Z **Commit 4:** removing unused variables/imports * Original sha: 9329501 * Authored by ppisljar <[email protected]> on 2016-09-08T15:23:24Z
ppisljar
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** converting to ES6 class syntax * Original sha: 161ba75 * Authored by ppisljar <[email protected]> on 2016-09-08T14:28:44Z **Commit 2:** let to const * Original sha: 9cb6b60 * Authored by ppisljar <[email protected]> on 2016-09-08T14:54:41Z **Commit 3:** fixing indentation to match our style * Original sha: 0b63b83 * Authored by ppisljar <[email protected]> on 2016-09-08T15:08:56Z **Commit 4:** removing unused variables/imports * Original sha: 9329501 * Authored by ppisljar <[email protected]> on 2016-09-08T15:23:24Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** converting to ES6 class syntax * Original sha: 3081ddcf83aeddd8339f1368b677b4f0ae2cd9ec [formerly 161ba75] * Authored by ppisljar <[email protected]> on 2016-09-08T14:28:44Z **Commit 2:** let to const * Original sha: 99bd02b6389a539b23654cca320967c4a9ac393f [formerly 9cb6b60] * Authored by ppisljar <[email protected]> on 2016-09-08T14:54:41Z **Commit 3:** fixing indentation to match our style * Original sha: 13e7932cf0e9a91f037a6f869b4a152d6d590402 [formerly 0b63b83] * Authored by ppisljar <[email protected]> on 2016-09-08T15:08:56Z **Commit 4:** removing unused variables/imports * Original sha: 581c9c5b66150026228e1eb2033109e4436b747c [formerly 9329501] * Authored by ppisljar <[email protected]> on 2016-09-08T15:23:24Z Former-commit-id: 5b51762
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8186 to 5.x Former-commit-id: c1c9986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparation for future work on vislib