New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.10] [Security Solutions][Detection Engine] Changes wording for threat matches and rules (#81334) #81835

Merged

peluja1012 merged 6 commits into elastic:7.10 from FrankHassanabad:backport/7.10/pr-81334

Oct 28, 2020

Contributor

FrankHassanabad commented Oct 27, 2020

Backports the following commits to 7.10:

[Security Solutions][Detection Engine] Changes wording for threat matches and rules ([Security Solutions][Detection Engine] Changes wording for threat matches and rules #81334)


          [Security Solutions][Detection Engine] Changes wording for threat mat…

44cb2f1

…ches and rules (elastic#81334)

## Summary

Changes the wording for threat matches and rules

cc @marrasherrier @MikePaquette @paulewing

Before:

<img width="1063" alt="Screen Shot 2020-10-21 at 8 52 44 AM" src="https://user-images.githubusercontent.com/1151048/96737354-ce1ee080-137a-11eb-973f-6a7d96f69117.png">

After:
<img width="1055" alt="Screen Shot 2020-10-26 at 10 10 17 PM" src="https://user-images.githubusercontent.com/1151048/97256235-1fdec500-17d8-11eb-8a8b-4adffd23dbdc.png">

### Checklist

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

FrankHassanabad added the backport label

Contributor Author

FrankHassanabad commented Oct 27, 2020

@elasticmachine merge upstream


          Merge branch '7.10' into backport/7.10/pr-81334

Contributor Author

FrankHassanabad commented Oct 27, 2020

@elasticmachine merge upstream


          Merge branch '7.10' into backport/7.10/pr-81334

bf33966

Contributor Author

FrankHassanabad commented Oct 28, 2020

@elasticmachine merge upstream


          Merge branch '7.10' into backport/7.10/pr-81334

61b4a11

Contributor Author

FrankHassanabad commented Oct 28, 2020

@elasticmachine merge upstream

kibanamachine and others added 2 commits

October 28, 2020 01:09


          Merge branch '7.10' into backport/7.10/pr-81334

4043dd8


          skips overview tests

e172722

Contributor

kibanamachine commented Oct 28, 2020

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e172722

Metrics [docs]

async chunks size

id	before	after	diff
`securitySolution`	10.5MB	10.5MB	+25.0B

History

💔 Build #84190 failed 4043dd8
💔 Build #84183 failed 61b4a11
💔 Build #84151 failed bf33966
💔 Build #84114 failed 3859577
💔 Build #84075 failed 44cb2f1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peluja1012 merged commit e4658ad into elastic:7.10

FrankHassanabad deleted the backport/7.10/pr-81334 branch

October 28, 2020 12:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels