[PoC] reporting csv generation from searchSource #81446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
ppisljar
added
release_note:skip
ppisljar
changed the title
tsullivan
reviewed
Oct 26, 2020
| title: savedSearch.title, | ||
| taskType: 'csv', | ||
| taskConfig: { | ||
| ...sharingData, |
There was a problem hiding this comment.
sharingData is the return value of searchSource.getSerializedFields:
"searchSource": {
"fields": [
"@date",
"name",
...
],
"filter": [],
"index": "bab57370-1266-11eb-aa87-cb7590d2fd4a",
"query": {
"language": "kuery",
"query": ""
},
"version": true
},
Would it be possible for CSV export to use just the ID of the saved search object as the params? If so, could the searchSource object come from that ID?
If someone has automated CSV export and makes changes to the saved search after scheduling the automation, their changes should be reflected in subsequent runs of the export.
There was a problem hiding this comment.
i think we should try to get away from dependency between csv report and existing saved search. This way we can create csv report on any search made with searchsource without requirement for backing saved search object (for example export csv from visulalization, or on discover without persisting the current view)
There was a problem hiding this comment.
It would be really interesting to see how that plays out, and I think we should carry on in this direction!
There is a related issue that could be solved with this approach: #18439 (see option 3)
tsullivan
reviewed
Dec 14, 2020
| searchRequest: sharingData.searchRequest as SearchRequest, | ||
| fields: sharingData.fields as string[], | ||
| metaFields: sharingData.metaFields as string[], | ||
| conflictedTypesFields: sharingData.conflictedTypesFields as string[], |
There was a problem hiding this comment.
This changes the object defining the job parameters, which is a breaking change. The job parameters are preserved in "POST URL" strings, which users copy into Watcher for automatic report generation.
Is it possible to keep BWC with the legacy parameters? If not, then we will create a new ExportTypeDefinition in Reporting.
There was a problem hiding this comment.
We'll create a new Export type definition
tsullivan
reviewed
Dec 14, 2020
| } | ||
| break; | ||
| const columns = table.columns.map((c) => { | ||
| // we are working on this utilities, its not there yet but should be in a week or so, which will get us the formatted values |
There was a problem hiding this comment.
@ppisljar will you be able to update this PR in the near future? This TODO should be taken care of by now
There was a problem hiding this comment.
yes i will continue working on this (after new year)
ppisljar
force-pushed
the
reporting/searchsource
branch
from
28073ef
to
66b7659
Compare
💔 Build Failed
Failed CI Steps
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/reporting·ts.discover Discover Generate CSV button becomes available when savedStandard OutStack TraceChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/reporting/download_csv·ts.dashboard Reporting Download CSV Downloads a CSV export of a saved search panelStandard OutStack TraceChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/secure_roles_perm·js.security app secure roles and permissions Kibana User navigating to Discover and trying to generate CSV gets - Authorization ErrorStandard OutStack Traceand 56 more failures, only showing the first 3. Metrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
I'm plan to pick up on this next week. |
|
Replaced with #88303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers