Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solutions][Detection Engine] Changes wording for threat matches and rules #81334

Merged
merged 9 commits into from
Oct 27, 2020
Merged

[Security Solutions][Detection Engine] Changes wording for threat matches and rules #81334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fa7e558
Changes wording for threat matches and rules
FrankHassanabad Oct 21, 2020
c2f7277
Merge branch 'master' into change-wording
FrankHassanabad Oct 22, 2020
b8bbfcc
Changed wording per feedback on PR review
FrankHassanabad Oct 22, 2020
684c0f5
Changes the wording for an extra field
FrankHassanabad Oct 23, 2020
da62998
Changed wording to Indicator Match for tests
FrankHassanabad Oct 23, 2020
ef0cf3b
Added some form reset logic for the threat match
FrankHassanabad Oct 23, 2020
5231c38
Merge branch 'master' into change-wording
FrankHassanabad Oct 26, 2020
be87c7d
Backed out change that was risky and instead am going to push the cha…
FrankHassanabad Oct 27, 2020
65390bd
Merge branch 'master' into change-wording
FrankHassanabad Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/common/components/threat_match/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const FIELD = i18n.translate('xpack.securitySolution.threatMatch.fieldDes
export const THREAT_FIELD = i18n.translate(
'xpack.securitySolution.threatMatch.threatFieldDescription',
{
defaultMessage: 'Threat index field',
defaultMessage: 'Indicator index field',
}
);

Expand Down
2 changes: 1 addition & 1 deletion ...ns/security_solution/public/detections/components/rules/description_step/helpers.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ describe('helpers', () => {
it('returns a humanized description for a threat_match type', () => {
const [result]: ListItems[] = buildRuleTypeDescription('Test label', 'threat_match');

expect(result.description).toEqual('Threat Match');
expect(result.description).toEqual('Indicator Match');
});
});
});
2 changes: 1 addition & 1 deletion ...ns/security_solution/public/detections/components/rules/description_step/translations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export const THRESHOLD_TYPE_DESCRIPTION = i18n.translate(
export const THREAT_MATCH_TYPE_DESCRIPTION = i18n.translate(
'xpack.securitySolution.detectionEngine.createRule.threatMatchRuleTypeDescription',
{
defaultMessage: 'Threat Match',
defaultMessage: 'Indicator Match',
}
);

Expand Down
5 changes: 3 additions & 2 deletions ...ins/security_solution/public/detections/components/rules/select_rule_type/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,14 @@ export const THRESHOLD_TYPE_DESCRIPTION = i18n.translate(
export const THREAT_MATCH_TYPE_TITLE = i18n.translate(
'xpack.securitySolution.detectionEngine.createRule.stepDefineRule.ruleTypeField.threatMatchTitle',
{
defaultMessage: 'Threat Match',
defaultMessage: 'Indicator Match',
}
);

export const THREAT_MATCH_TYPE_DESCRIPTION = i18n.translate(
'xpack.securitySolution.detectionEngine.createRule.stepDefineRule.ruleTypeField.threatMatchDescription',
{
defaultMessage: 'Upload value lists to write rules around a list of known bad attributes',
defaultMessage:
'Use indicators from intelligence sources to detect matching events and alerts.',
}
);
6 changes: 3 additions & 3 deletions .../plugins/security_solution/public/detections/components/rules/step_define_rule/schema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export const schema: FormSchema<DefineStepRule> = {
label: i18n.translate(
'xpack.securitySolution.detectionEngine.createRule.stepDefineRule.fieldThreatIndexPatternsLabel',
{
defaultMessage: 'Threat index patterns',
defaultMessage: 'Indicator Index Patterns',
}
),
helpText: <EuiText size="xs">{THREAT_MATCH_INDEX_HELPER_TEXT}</EuiText>,
Expand Down Expand Up @@ -265,7 +265,7 @@ export const schema: FormSchema<DefineStepRule> = {
label: i18n.translate(
'xpack.securitySolution.detectionEngine.createRule.stepDefineRule.fieldThreatMappingLabel',
{
defaultMessage: 'Threat Mapping',
defaultMessage: 'Indicator Mapping',
}
),
validations: [
Expand Down Expand Up @@ -301,7 +301,7 @@ export const schema: FormSchema<DefineStepRule> = {
label: i18n.translate(
'xpack.securitySolution.detectionEngine.createRule.stepDefineRule.fieldThreatQueryBarLabel',
{
defaultMessage: 'Threat index query',
defaultMessage: 'Indicator Index Query',
}
),
validations: [
Expand Down
2 changes: 1 addition & 1 deletion ...solution/server/lib/detection_engine/scripts/rules/queries/query_with_threat_mapping.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "Query with a threat mapping",
"name": "Query with a indicator mapping",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super duper nit:

Suggested change
"name": "Query with a indicator mapping",
"name": "Query with an indicator mapping",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap missed this after the merge! Thanks though, this shows the level you're looking at the code. I appreciate it. Always nervous of making simple slip ups in the UI.

"description": "Query with a threat mapping",
"rule_id": "threat-mapping",
"risk_score": 1,
Expand Down