[Discover] Unskip functional sidebar test

[kertal]

Summary

Confirmed to be flaky by using the flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/912/, which failed with the following screen

It's checking for the sidebar filter to be hidden ... in the screenshot it's hidden, that's what's happening in the logs:

[00:16:03]               └-> "before all" hook
[00:16:03]               └-> should reveal and hide the filter form when the toggle is clicked
[00:16:03]                 └-> "before each" hook: global before each
[00:16:03]                 │ debg TestSubjects.click(toggleFieldFilterButton)
[00:16:03]                 │ debg Find.clickByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg Find.findByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg TestSubjects.exists(filterSelectionPanel)
[00:16:03]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="filterSelectionPanel"]') with timeout=120000
[00:16:03]                 │ debg TestSubjects.click(toggleFieldFilterButton)
[00:16:03]                 │ debg Find.clickByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg Find.findByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg TestSubjects.missingOrFail(filterSelectionPanel)
[00:16:03]                 │ debg TestSubjects.waitForHidden(filterSelectionPanel)
[00:16:03]                 │ debg TestSubjects.find(filterSelectionPanel)
[00:16:03]                 │ debg Find.findByCssSelector('[data-test-subj="filterSelectionPanel"]') with timeout=10000
[00:16:05]                 │ debg Find.waitForElementHidden with timeout=2500
[00:16:05]                 │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app discover sidebar field filtering should reveal and hide the filter form when the toggle is clicked.png"

This PR fixes this flakiness, but also the flaky tests runner uncovers another flakiness by a different test:

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/925/

Here discover app discover doc table add and remove columns should remove columns from the table is failing in a flaky way, started #82430 for this

Fixes #80914

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 92dce2e

Metrics [docs]

✅ unchanged

History

• 💚 Build #82995 succeeded a1061e1
• 💚 Build #82819 succeeded ea69e7f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[spalger]

This PR fixes this flakiness, but also the flaky tests runner uncovers another flakiness by a different test:

Sounds like we can't merge this until the other flakiness is fixed too. Sounds like we should merge the two PRs because we can't unskip the suite until it's not flaky.

[kertal]

This PR fixes this flakiness, but also the flaky tests runner uncovers another flakiness by a different test:

Sounds like we can't merge this until the other flakiness is fixed too. Sounds like we should merge the two PRs because we can't unskip the suite until it's not flaky.

@spalger The new flaky ones are in a different file (_doc_table.ts), but in the same group, that's why I couldn't get a flaky test without failures (ran the whole group)

[spalger]

LGTM