Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btsymbala/keyboard accesibility trusted app deletion #81156

Conversation

efreeti
Copy link
Contributor

@efreeti efreeti commented Oct 20, 2020

Most of keyboard accessibility of modal popup and buttons was already in place so I've added auto focusing of confirm button in trusted app deletion dialog.

Checklist

@efreeti efreeti added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature labels Oct 20, 2020
@efreeti efreeti requested review from a team as code owners October 20, 2020 13:07
@efreeti efreeti self-assigned this Oct 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 8.1MB 8.1MB +835.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efreeti efreeti added v7.11.0 and removed v7.10 labels Oct 20, 2020
@efreeti efreeti merged commit 02c8c36 into elastic:master Oct 20, 2020
@efreeti efreeti deleted the btsymbala/keyboard-accesibility-trusted-app-deletion branch October 20, 2020 16:13
efreeti added a commit to efreeti/kibana that referenced this pull request Oct 20, 2020
* Added auto focusing of confirm button in trusted apps deletion dialog on opening.

* Updated snapshots.

* Updated snapshots after kbn:bootstrap.
efreeti added a commit that referenced this pull request Oct 21, 2020
* Added auto focusing of confirm button in trusted apps deletion dialog on opening.

* Updated snapshots.

* Updated snapshots after kbn:bootstrap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants