Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin generator] Update readme #81131

Merged
merged 1 commit into from
Oct 25, 2020
Merged

[Plugin generator] Update readme #81131

merged 1 commit into from
Oct 25, 2020

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Oct 20, 2020

yarn start shoud be ran from kibana root.

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 20, 2020
@Bamieh Bamieh requested a review from spalger October 20, 2020 10:58
spalger
spalger approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh Bamieh merged commit 82ba41c into elastic:master Oct 25, 2020
@Bamieh Bamieh deleted the plugin_generator/update_readme branch October 25, 2020 12:35
@Bamieh Bamieh mentioned this pull request Oct 25, 2020
Merged
Bamieh added a commit that referenced this pull request Oct 25, 2020
@Bamieh
[7.x] [Plugin generator] Update readme (#81131) (#81578)
27163f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bamieh @spalger