[Enterprise Search] Fix users being logged out of Kibana if Enterprise Search returns a 401

[cee-chen]

Summary

At some point between 7.9 and 7.10, Enterprise Search started returning 401 responses (instead of /login redirects) when users were unauthenticated or did not exist (e.g. standard auth).

We need to expand our handleAuthenticationError catch to check for 401 responses as well so we don't pass them back to Kibana - Kibana responds to 401 status codes by logging the user out of Kibana, which we don't want to do in this case.

QA

• Start Enterprise Search on standard auth
• Log in to Kibana as the elastic user
• Attempt to access App Search or Workplace Search
• Confirm that you are:
  • NOT logged out / see an error connecting screen
  • See a [error][enterpriseSearch][plugins] Cannot authenticate Enterprise Search user message in the Kibana terminal logs

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[cee-chen]

@orhantoy Let me know if you think we can remove redirect checks going forward - I might leave it in for now just in case users are somehow using mismatched Enterprise Search / Kibana versions, but would be good to potentially clean up down the road

[scottybollinger]

Since this is destructured above, we can get rid of apiResponse. here. I'd also submit that you can also destructure url and clan this up a bit below

EDIT: I see that url is already declared in scope. Perhaps:

const { status, url: responseUrl } = apiResponse;
...
responseUrl.endsWith('/login') ||
responseUrl.endsWith('/ent/select')

... but that doesn't really help much

[scottybollinger]

LGTM. Left a nit comment but feel free to ignore if you like

[cee-chen]

Ahhh thanks for that scotty. I actually don't even know why I moved the destructure up above since I'm not even using it lol 🤦‍♀️ I'm gonna move it back down but leave it un-destructured for now, I'm hoping eventually we can clean up our if statement for unauthenticated users anyway if/when @orhantoy confirms that we'll likely never run into redirects from Kibana going forward.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f97b7a0

Metrics [docs]

✅ unchanged

History

• 💚 Build #82036 succeeded bf851afce46bb5e2c54ea904d360a278410d8c41

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream