-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.10] Use SavedObjectClass
from savedObject
start contract instead of createSavedObjectClass
(#80063)
#80458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…createSavedObjectClass` (elastic#80063) * no longer export static createSavedObjectClass from savedObject plugin * fix forgotten call * yet another usage * more fixes * move so to required plugins for timelion # Conflicts: # src/plugins/dashboard/public/plugin.tsx # src/plugins/visualizations/kibana.json # src/plugins/visualizations/public/plugin.ts
💔 Build Failed
Failed CI Steps
Test FailuresChrome UI Functional Tests.test/functional/apps/dashboard/dashboard_clone·js.dashboard app using legacy data dashboard clone the copy should have all the same visualizationsStandard Out
Stack Trace
X-Pack Accessibility Tests.x-pack/test/accessibility/apps/dashboard_edit_panel·ts.Dashboard Edit Panel A11y test on dashboard embeddable clone panelStandard Out
Stack Trace
Accessibility Tests.test/accessibility/apps/dashboard_panel·ts.Dashboard Panel dashboard panel openStandard Out
Stack Trace
and 9 more failures, only showing the first 3. Metrics [docs]async chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.10:
SavedObjectClass
fromsavedObject
start contract instead ofcreateSavedObjectClass
(UseSavedObjectClass
fromsavedObject
start contract instead ofcreateSavedObjectClass
#80063)