Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up filter creation in functional tests #80037

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Speed up filter creation in functional tests #80037

merged 3 commits into from
Oct 14, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Oct 8, 2020

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 8, 2020
@lizozom lizozom self-assigned this Oct 8, 2020
@lizozom lizozom marked this pull request as ready for review October 9, 2020 09:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom requested a review from spalger October 9, 2020 09:31
@lizozom
Copy link
Contributor Author

lizozom commented Oct 12, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Oct 12, 2020

Would you mind testing this out a few times with the flaky suite runner to understand if this causes any flakiness in big consumers of the service?

@lizozom
Copy link
Contributor Author

lizozom commented Oct 13, 2020

@splager running https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/899/

@spalger
Copy link
Contributor

spalger commented Oct 13, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger
spalger approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200 successful executions with https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/903/ and https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/904/, LGTM

@lizozom lizozom merged commit c547d62 into elastic:master Oct 14, 2020
@lizozom lizozom mentioned this pull request Oct 14, 2020
Merged
lizozom added a commit to lizozom/kibana that referenced this pull request Oct 14, 2020
@lizozom @kibanamachine
Speed up filter creation in functional tests (elastic#80037)
c3ffdc2 
Co-authored-by: Kibana Machine <[email protected]>
lizozom added a commit that referenced this pull request Oct 14, 2020
@lizozom @kibanamachine
Speed up filter creation in functional tests (#80037) (#80507)
189c660 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@lizozom lizozom

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizozom @elasticmachine @spalger @kibanamachine