Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timelion y-axis label not displayed #80007

Merged
merged 11 commits into from
Oct 14, 2020
Merged

Timelion y-axis label not displayed #80007

merged 11 commits into from
Oct 14, 2020

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Oct 8, 2020 •
edited
Loading

Closes: #79486

Summary

Since we had 4 versions of flots after each subsequent initialization, we cleared all the previous plugins for plot.
To solve the problem, moved the 'flot' to ui-shared-deps and left only one version.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa requested review from spalger and timroes October 8, 2020 15:06
@VladLasitsa VladLasitsa changed the title Moved flot in ui-shared-deps and leavt only one version. Moved flot in ui-shared-deps and left only one version. Oct 8, 2020
@VladLasitsa VladLasitsa changed the title Moved flot in ui-shared-deps and left only one version. Timelion y-axis label not displayed Oct 8, 2020
sulemanof
sulemanof approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Checked locally, works as expected! Thanks!

spalger
spalger approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VladLasitsa VladLasitsa added design-only Can be handled solely by a design team member release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v7.11.0 v8.0.0 and removed design-only Can be handled solely by a design team member labels Oct 12, 2020
@VladLasitsa VladLasitsa marked this pull request as ready for review October 12, 2020 09:58
@VladLasitsa VladLasitsa requested a review from a team October 12, 2020 09:58
@VladLasitsa VladLasitsa requested review from a team as code owners October 12, 2020 09:58
@VladLasitsa VladLasitsa requested a review from a team October 12, 2020 09:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

alexwizp
alexwizp approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stratoula
stratoula approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally on Safari 👏

chrisronline
chrisronline approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for stack monitoring. I stood this up locally and pointed to a cloud monitoring cluster and compared the graphs for a few pages and it looks like everything works the same

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
canvas 1132 1121 -11
monitoring 638 632 -6
timelion 99 91 -8
visTypeTimelion 45 37 -8
total -33

@kbn/ui-shared-deps asset size

id before after diff
[email protected] 2.4MB 2.4MB +14.0B
kbn-ui-shared-deps.js 4.7MB 4.7MB +68.8KB
total +68.8KB

async chunks size

id before after diff
canvas 1.5MB 1.4MB -76.9KB
monitoring 1.2MB 1.1MB -67.2KB
timelion 461.2KB 382.4KB -78.8KB
visTypeTimelion 154.2KB 75.4KB -78.8KB
total -301.7KB

distributable file count

id before after diff
default 48492 48491 -1
oss 29191 29211 +20

page load bundle size

id before after diff
canvas 1.0MB 1014.7KB -12.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611
crob611 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes look good and work as expected. 👍

@VladLasitsa VladLasitsa merged commit ba8e9a5 into elastic:master Oct 14, 2020
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Oct 14, 2020
@VladLasitsa @spalger @kibanamachine
Timelion y-axis label not displayed (elastic#80007)
439b2a4 
* Moved flot in ui-shared-deps and leavt only one version.

* Removed unneeded import

* use commonJS so we can execute code between loading specific modules

* prefix i18n keys with flot.

* Fix Internationalization

* remove duplicate pie plugin

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@VladLasitsa VladLasitsa mentioned this pull request Oct 14, 2020
Merged
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Oct 14, 2020
@VladLasitsa @spalger @kibanamachine
Timelion y-axis label not displayed (elastic#80007)
8df5de1 
* Moved flot in ui-shared-deps and leavt only one version.

* Removed unneeded import

* use commonJS so we can execute code between loading specific modules

* prefix i18n keys with flot.

* Fix Internationalization

* remove duplicate pie plugin

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@VladLasitsa VladLasitsa mentioned this pull request Oct 14, 2020
Merged
@timroes timroes added the Feature:Timelion Timelion app and visualization label Oct 15, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 16, 2020
VladLasitsa added a commit that referenced this pull request Oct 16, 2020
@VladLasitsa @spalger @kibanamachine
[7.x] Timelion y-axis label not displayed (#80007) (#80521)
f300a41 
* Timelion y-axis label not displayed (#80007)

* Moved flot in ui-shared-deps and leavt only one version.

* Removed unneeded import

* use commonJS so we can execute code between loading specific modules

* prefix i18n keys with flot.

* Fix Internationalization

* remove duplicate pie plugin

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

* Fix test.

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
VladLasitsa added a commit that referenced this pull request Oct 16, 2020
@VladLasitsa @spalger @kibanamachine
[7.10] Timelion y-axis label not displayed (#80007) (#80523)
7503ad2 
* Timelion y-axis label not displayed (#80007)

* Moved flot in ui-shared-deps and leavt only one version.

* Removed unneeded import

* use commonJS so we can execute code between loading specific modules

* prefix i18n keys with flot.

* Fix Internationalization

* remove duplicate pie plugin

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

* Fix test

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanof sulemanof sulemanof approved these changes

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

@spalger spalger spalger approved these changes

@crob611 crob611 crob611 approved these changes

@chrisronline chrisronline chrisronline approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees
No one assigned
Labels
Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timelion y-axis label not displayed
10 participants
@VladLasitsa @elasticmachine @kibanamachine @chrisronline @crob611 @spalger @stratoula @alexwizp @sulemanof @timroes