Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] share tslib across bundles (#79915) #79929

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 7, 2020

Backports the following commits to 7.x:

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
apm 1272 1271 -1
console 172 170 -2
core 441 440 -1
expressions 107 105 -2
globalSearchBar 23 21 -2
home 208 207 -1
infra 1147 1142 -5
ingestManager 549 548 -1
kibanaReact 307 306 -1
kibanaUtils 193 192 -1
lens 564 563 -1
logstash 190 189 -1
ml 1220 1218 -2
searchprofiler 87 85 -2
securitySolution 2043 2038 -5
transform 339 337 -2
triggersActionsUi 285 283 -2
uptime 657 656 -1
visDefaultEditor 241 240 -1
visualize 207 206 -1
watcher 238 237 -1
total -36

@kbn/ui-shared-deps asset size

id before after diff
kbn-ui-shared-deps.js 4.7MB 4.7MB +47.0B

async chunks size

id before after diff
apm 4.1MB 4.1MB -9.5KB
console 1.1MB 1.0MB -10.0KB
home 404.0KB 394.5KB -9.5KB
infra 3.8MB 3.8MB -47.6KB
ingestManager 1.3MB 1.2MB -9.5KB
kibanaReact 358.7KB 359.0KB +328.0B
lens 1.1MB 1.0MB -9.5KB
logstash 213.4KB 203.9KB -9.5KB
ml 11.3MB 11.2MB -39.1KB
searchprofiler 705.1KB 695.1KB -10.0KB
securitySolution 10.5MB 10.5MB -47.6KB
transform 1.2MB 1.2MB -19.4KB
triggersActionsUi 1.5MB 1.5MB -10.0KB
uptime 1.7MB 1.7MB -9.5KB
visDefaultEditor 458.6KB 449.1KB -9.5KB
visualize 274.1KB 264.6KB -9.5KB
watcher 1.0MB 1.0MB -9.9KB
total -269.2KB

page load bundle size

id before after diff
apm 48.2KB 48.3KB +65.0B
console 30.5KB 30.6KB +65.0B
core 661.8KB 652.4KB -9.4KB
expressions 204.2KB 194.6KB -9.6KB
globalSearchBar 46.8KB 37.2KB -9.6KB
home 26.0KB 26.1KB +65.0B
infra 178.6KB 178.7KB +65.0B
ingestManager 391.4KB 391.5KB +65.0B
kibanaReact 143.9KB 134.3KB -9.6KB
kibanaUtils 179.5KB 170.1KB -9.4KB
lens 79.7KB 79.8KB +65.0B
logstash 37.6KB 37.7KB +65.0B
ml 65.6KB 65.7KB +65.0B
searchprofiler 51.0KB 51.1KB +65.0B
securitySolution 593.2KB 593.2KB +65.0B
transform 25.5KB 25.6KB +65.0B
triggersActionsUi 151.5KB 151.6KB +65.0B
uptime 25.2KB 25.3KB +65.0B
visDefaultEditor 34.4KB 34.4KB +65.0B
visualize 41.4KB 41.5KB +65.0B
watcher 28.1KB 28.1KB +65.0B
total -46.7KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 8472a86 into elastic:7.x Oct 7, 2020
@spalger spalger deleted the backport/7.x/pr-79915 branch October 7, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants