Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Inventory view cleanup #79881

Merged
merged 17 commits into from
Oct 14, 2020
Merged

[Metrics UI] Inventory view cleanup #79881

merged 17 commits into from
Oct 14, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 7, 2020 •
edited
Loading

Summary

Closes #78781, mostly fixes the issues in there.

  • UI is now readable and usable on smaller screens, while still far from perfect. I think it'd be good for us to do a small screen design ticket:

Screen Shot 2020-10-07 at 1 38 07 PM

Screen Shot 2020-10-07 at 1 38 52 PM

  • "Loading Data Sources" indicator no longer wraps to 2 lines on small screens
  • Waffle map is no longer overlapped by the UI on smaller screens
  • Waffle map legend is now centered on the screen
  • Fixed wording on "Unable to show historical data" messages
  • Fixed sentence case on metric popovers on the timeline
  • Fixed color legend on the timeline
  • Added background color to Show History button

Checklist

@Zacqary Zacqary added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 7, 2020
@Zacqary Zacqary requested a review from a team as a code owner October 7, 2020 17:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor Author

Zacqary commented Oct 12, 2020

@elasticmachine merge upstream

@Kerry350 Kerry350 self-requested a review October 14, 2020 11:17
Kerry350
Kerry350 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for the most part 🎉

I did find I could get into a state where I couldn't access / see the waffle map anymore though:

metrics-responsive

I've approved anyway, so this can make it into the release, as it's already a big improvement, but this might need an additional followup?

@Zacqary
Copy link
Contributor Author

Zacqary commented Oct 14, 2020

@elasticmachine merge upstream

@Zacqary
Copy link
Contributor Author

Zacqary commented Oct 14, 2020

@Kerry350 I'll take another look and see if I can reproduce. We still have table layout to fall back to, and I know we're considering just disabling the waffle map on small portrait screens.

I'm guessing it's related to the screen being very thin but also very tall. I optimized the waffle map so it'd still be scrollable to on an iPhone-sized screen, so maybe something got lost when resizing a desktop browser this way.

@Zacqary
Copy link
Contributor Author

Zacqary commented Oct 14, 2020

Actually it was because I set the Waffle Map to display: static only at the xs breakpoint when it also needed it at s. Pushing a fix.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
infra 3.8MB 3.8MB +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit f3ee7a3 into elastic:master Oct 14, 2020
@Zacqary Zacqary deleted the 78781-inventory-cleanup branch October 14, 2020 21:34
This was referenced Oct 14, 2020
Merged
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Oct 14, 2020
@Zacqary @kibanamachine
[Metrics UI] Inventory view cleanup (elastic#79881)
4003cf8 
* Add background to Show History

* Fix legend centering

* Fix sentence casing in timeline popovers

* Improve small-screen responsiveness of filter dropdowns

* Improve top action responsiveness

* Remove unneeded align center

* Improve waffle map small screen responsiveness

* Fix inventory timeline color legend

* Fix loading spinner wrap

* Fix color legend

* Improve filter responsiveness

* Fix z-index on view switcher

* Move manage views flyout into portal

* Set waffle map to di display: static at s breakpoint

Co-authored-by: Kibana Machine <[email protected]>
Zacqary added a commit to Zacqary/kibana that referenced this pull request Oct 14, 2020
@Zacqary @kibanamachine
[Metrics UI] Inventory view cleanup (elastic#79881)
efb5533 
* Add background to Show History

* Fix legend centering

* Fix sentence casing in timeline popovers

* Improve small-screen responsiveness of filter dropdowns

* Improve top action responsiveness

* Remove unneeded align center

* Improve waffle map small screen responsiveness

* Fix inventory timeline color legend

* Fix loading spinner wrap

* Fix color legend

* Improve filter responsiveness

* Fix z-index on view switcher

* Move manage views flyout into portal

* Set waffle map to di display: static at s breakpoint

Co-authored-by: Kibana Machine <[email protected]>
Zacqary added a commit that referenced this pull request Oct 15, 2020
@Zacqary @kibanamachine
[7.x] [Metrics UI] Inventory view cleanup (#79881) (#80594)
9110a83 
* Add background to Show History

* Fix legend centering

* Fix sentence casing in timeline popovers

* Improve small-screen responsiveness of filter dropdowns

* Improve top action responsiveness

* Remove unneeded align center

* Improve waffle map small screen responsiveness

* Fix inventory timeline color legend

* Fix loading spinner wrap

* Fix color legend

* Improve filter responsiveness

* Fix z-index on view switcher

* Move manage views flyout into portal

* Set waffle map to di display: static at s breakpoint

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@weltenwort
Copy link
Member

💭 If we consider this a bugfix and backport it to 7.10, should we label it as such?

gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 15, 2020
@gmmorris
Merge branch 'master' into task-manager/health
1c4c266 
* master: (102 commits)
  [Resolver] Fix flaky test (elastic#80576)
  Update Security Solution Bug Report Template (elastic#80668)
  [Observability] Kibana home page Observability link pointing to `/landing` (elastic#80636)
  [APM] Update User Experience app callout code to reflect new name (elastic#80641)
  [APM] Add missing ML privileges (elastic#80553)
  [DOCS] Adds intro line to the ML plugin readme file (elastic#80631)
  [ML] Functional tests - fix and re-enable validation API tests (elastic#80617)
  remove non-existing dependency from uptime plugin (elastic#80623)
  [ML] Fix job selection flyout overflow (elastic#80621)
  Move dashboard code in codeowner files to canvas team (elastic#80345)
  [Security Solution][Detections] Update signals template if outdated and rollover indices (elastic#80019)
  Sort service list by TPM if health is not shown (elastic#80447)
  Add in cluster version for sec telemetry sender. (elastic#80545)
  [Usage Collection] Usage collection add saved objects client to collector fetch context (elastic#80554)
  Change tag from experimental to beta (elastic#80443)
  [Metrics UI] Inventory view cleanup (elastic#79881)
  [Security Solutions][Detection Engine] Critical bug where value lists were not operational (elastic#80368)
  [Security Solution] Fix networkTopNFlow search strategy response (elastic#80362)
  [build] Retry docker pull (elastic#80432)
  add template for Security Solution bugs (elastic#80574)
  ...
Zacqary added a commit that referenced this pull request Oct 15, 2020
@Zacqary @kibanamachine
[7.10] [Metrics UI] Inventory view cleanup (#79881) (#80596)
4a02a2c 
* Add background to Show History

* Fix legend centering

* Fix sentence casing in timeline popovers

* Improve small-screen responsiveness of filter dropdowns

* Improve top action responsiveness

* Remove unneeded align center

* Improve waffle map small screen responsiveness

* Fix inventory timeline color legend

* Fix loading spinner wrap

* Fix color legend

* Improve filter responsiveness

* Fix z-index on view switcher

* Move manage views flyout into portal

* Set waffle map to di display: static at s breakpoint

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience v7.11.0 labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] inventory view cleanup
5 participants
@Zacqary @elasticmachine @kibanamachine @weltenwort @Kerry350