Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Add median/percentile info in titles #79824

Merged
merged 15 commits into from
Oct 28, 2020
Merged

[UX] Add median/percentile info in titles #79824

merged 15 commits into from
Oct 28, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 7, 2020 •
edited
Loading

Summary

Fixed point 17 from issue #78261
Added information to display whether the displayed metric is median, 75th Percentile to reflect selected calculation method.

Renamed User experience metrics, to just metrics

image

Also renamed page view to Total page views to make it more clear that it's not median

image

In the URL search, for individual page load duration
image

image

@shahzad31 shahzad31 changed the title update titles [UX] Add median/percentile info in titles Oct 26, 2020
@shahzad31 shahzad31 marked this pull request as ready for review October 26, 2020 14:12
@shahzad31 shahzad31 requested a review from a team as a code owner October 26, 2020 14:12
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Oct 26, 2020
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@shahzad31
Copy link
Contributor Author

jenkins run the e2e

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31 shahzad31 requested a review from formgeist October 27, 2020 10:29
@Kerry350 Kerry350 self-requested a review October 27, 2020 10:32
formgeist
formgeist approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor label suggestions

x-pack/plugins/apm/public/components/app/RumDashboard/translations.ts Outdated Show resolved Hide resolved
@paulb-elastic paulb-elastic mentioned this pull request Oct 27, 2020
Closed
15 tasks
Kerry350
Kerry350 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

One minor thing, is it worth putting: percentile === 50 ? I18LABELS.median : getPercentileLabel(percentile!) into a reusable function as it comes up quite a few times?

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Oct 28, 2020
@shahzad31 shahzad31 requested a review from a team as a code owner October 28, 2020 09:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.3MB 3.3MB +733.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit e3f9649 into elastic:master Oct 28, 2020
@shahzad31 shahzad31 deleted the perc-in-title branch October 28, 2020 11:16
@shahzad31 shahzad31 mentioned this pull request Oct 28, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 28, 2020
@shahzad31 @kibanamachine
[UX] Add median/percentile info in titles (elastic#79824)
4e55eb4 
Co-authored-by: Kibana Machine <[email protected]>
@shahzad31 shahzad31 mentioned this pull request Oct 28, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 28, 2020
@shahzad31 @kibanamachine
[UX] Add median/percentile info in titles (elastic#79824)
e237a75 
Co-authored-by: Kibana Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Oct 28, 2020
@shahzad31 @kibanamachine
[7.10] [UX] Add median/percentile info in titles (#79824) (#81887)
3f7bbe0 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Oct 28, 2020
@shahzad31 @kibanamachine
[7.x] [UX] Add median/percentile info in titles (#79824) (#81886)
1f40479 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 29, 2020
@gmmorris
Merge branch 'alerts/convert-to-tm-intervals' of github.com:gmmorris/…
93ba119 
…kibana into alerts/convert-to-tm-intervals

* 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits)
  fixed jest
  APM Experiments settings (elastic#81554)
  [Resolver] Enable resolver test plugin tests (elastic#81339)
  Add TS project references for inspector  (elastic#81792)
  Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835)
  [Fleet] Rename ingestManager translations fleet (elastic#81837)
  [Logs UI] Transmit and render array field values in log entries (elastic#81385)
  Audit Logging: use the original url (elastic#81282)
  [User experience] Fix JS error rate (elastic#81512)
  [UX] Add median/percentile info in titles (elastic#79824)
  Support export for SO with circular refs (elastic#81582)
  Get rid of  global types (elastic#81739)
  [APM] Fix precommit script (elastic#81594)
  skips overview tests (elastic#81877)
  [Security Solution][Case] Fix connector's labeling (elastic#81824)
  Added simple test, which only covers successful case when edit happened right after task was complete previous execution
  [Maps] Fix EMS test (elastic#81856)
  [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783)
  skip flaky suite (elastic#81853)
  Fixed type checks and unit tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist approved these changes

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @elasticmachine @kibanamachine @Kerry350 @formgeist