[Security Solution][Detections] Fix EQL search request filter when built with exceptions #79753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallmain
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
spong
reviewed
Oct 6, 2020
| @@ -110,27 +110,35 @@ export const buildEqlSearchRequest = ( | |||
| exceptionFilter = buildExceptionFilter(exceptionQueries, indexPattern, config, true, 1024); | |||
| } | |||
| const indexString = index.join(); | |||
| const requestFilter: unknown[] = [ | |||
There was a problem hiding this comment.
I believe you could use EsRangeFilter here in place of the unknown:
Suggested change
| const requestFilter: unknown[] = [ | |
| const requestFilter: EsRangeFilter[] = [ |
There was a problem hiding this comment.
Actually, since you're pushing the bool object below as well, not sure what the recommended generic Filter type that should be used here...
marshallmain
added a commit
to marshallmain/kibana
that referenced
this pull request
Oct 6, 2020
spong
pushed a commit
that referenced
this pull request
Oct 7, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ES query DSL does not support multiple objects within a
filterobject, which is how we were attempting to build the query. Instead,filterneeds to be an array of objects. The EQL search API does not allow the top levelfilterto be an array so we have to nest thefilterarray within anotherboolobject.Checklist
Delete any items that are not applicable to this PR.
For maintainers