Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Extend DiscoverNoResults component to show different message on error #79671

Merged
merged 15 commits into from
Oct 21, 2020
Merged

[Discover] Extend DiscoverNoResults component to show different message on error #79671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f26dbf4
Extend DiscoverNoResults component to show different message on error
kertal Oct 6, 2020
e65a9af
Merge branch 'master' into kertal-pr-2020-10-06-discover-add-static-e…
kibanamachine Oct 6, 2020
c8c4434
Merge branch 'master' into kertal-pr-2020-10-06-discover-add-static-e…
kibanamachine Oct 7, 2020
30f39fa
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-10…
kertal Oct 15, 2020
a27559d
Merge branch 'kertal-pr-2020-10-06-discover-add-static-error-message'…
kertal Oct 15, 2020
f6a51b3
Merge branch 'master' into kertal-pr-2020-10-06-discover-add-static-e…
kibanamachine Oct 15, 2020
3728c23
Merge branch 'kertal-pr-2020-10-06-discover-add-static-error-message'…
kertal Oct 15, 2020
23db6e0
Address review comments
kertal Oct 16, 2020
3b33603
Merge branch 'master' into kertal-pr-2020-10-06-discover-add-static-e…
kibanamachine Oct 19, 2020
786cc34
Improve code, refactor to helper file
kertal Oct 19, 2020
3cca99e
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-10…
kertal Oct 20, 2020
b0215d8
Refactor improving everything
kertal Oct 20, 2020
94d346e
Update src/plugins/discover/public/application/components/no_results/…
kertal Oct 21, 2020
6e7256d
Update src/plugins/discover/public/application/components/no_results/…
kertal Oct 21, 2020
b07f58d
Satisfy linting
kertal Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
218 changes: 0 additions & 218 deletions ...gins/discover/public/application/angular/directives/__snapshots__/no_results.test.js.snap
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/plugins/discover/public/application/angular/directives/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
@import 'no_results';
@import 'histogram';
14 changes: 2 additions & 12 deletions ...c/application/angular/directives/index.js → ...c/application/angular/directives/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,5 @@
* under the License.
*/

import { DiscoverNoResults } from './no_results';
import { DiscoverUninitialized } from './uninitialized';
import { DiscoverHistogram } from './histogram';
import { getAngularModule } from '../../../kibana_services';

const app = getAngularModule();

app.directive('discoverNoResults', (reactDirective) => reactDirective(DiscoverNoResults));

app.directive('discoverUninitialized', (reactDirective) => reactDirective(DiscoverUninitialized));

app.directive('discoverHistogram', (reactDirective) => reactDirective(DiscoverHistogram));
export { DiscoverUninitialized } from './uninitialized';
export { DiscoverHistogram } from './histogram';
Loading