Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more aggressive lazy loading for ingest_manager #79633

Merged
merged 2 commits into from
Oct 6, 2020
Merged

more aggressive lazy loading for ingest_manager #79633

merged 2 commits into from
Oct 6, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Oct 6, 2020 •
edited
Loading

Summary

Plugin entry bundle size:
537K --> 390K

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 6, 2020
@mshustov mshustov marked this pull request as ready for review October 6, 2020 12:18
@mshustov mshustov requested a review from a team October 6, 2020 12:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
ingestManager 548 549 +1

async chunks size

id before after diff
ingestManager 1.1MB 1.3MB +154.2KB

distributable file count

id before after diff
default 48282 48297 +15

page load bundle size

id before after diff
ingestManager 536.9KB 391.1KB -145.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jfsiii
jfsiii approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated local env errors kept me from running this locally.

It reads well to me and the build stats show shifting the code to async chunks.

Approved if you want to ship.

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@mshustov mshustov merged commit cc7ac29 into elastic:master Oct 6, 2020
@mshustov mshustov deleted the slim-ingest-manager branch October 6, 2020 16:57
mshustov added a commit to mshustov/kibana that referenced this pull request Oct 6, 2020
@mshustov
more aggressive lazy loading for ingest_manager (elastic#79633)
feeb8e1 
* slim ingest_manager

* revert registerPackagePolicyComponent export
@mshustov mshustov mentioned this pull request Oct 6, 2020
Merged
mshustov added a commit that referenced this pull request Oct 6, 2020
@mshustov
more aggressive lazy loading for ingest_manager (#79633) (#79713)
570f2d2 
* slim ingest_manager

* revert registerPackagePolicyComponent export
@jen-huang jen-huang mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfsiii jfsiii jfsiii approved these changes

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshustov @elasticmachine @kibanamachine @jfsiii