[Visualize] New visualization wizard #79627

stratoula · 2020-10-06T08:43:17Z

Summary

Missing:

~~The new vega icon should be updated on the EUI~~ How will we handle the vega icon? Group visualization into "experience" groups in the new visualization wizard #73418 (comment)
Final Texts
The controls vis should be flagged as experimental, missing the design

New visualization wizard. It actually introduces experience groups for the first step and all the aggregation based visualizations have been moved to a second step under the aggbased group.
Another change is that now both Lens and Maps are displayed on OSS but disabled.

First step, Basic

First step, OSS

Aggregation based visualizations as cards

Index pattern selection step is the same but a little bit bigger to have the same size as the previous steps

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

stratoula · 2020-10-07T14:56:30Z

@elasticmachine merge upstream

src/plugins/lens_oss/public/plugin.ts

src/plugins/maps_oss/public/plugin.ts

stratoula · 2020-10-08T08:44:33Z

src/plugins/visualizations/public/vis_types/vis_type_alias_registry.ts

@@ -42,19 +42,15 @@ export interface VisualizationsAppExtension {
  }) => VisualizationListItem;
 }

-export interface VisTypeAliasPromotion {
-  description: string;


ℹ️ As we don't have the section to promote a visualization with a description and a button I have removed this and changed this to a boolean in case we want in the future to visually differentiate the lens card

stratoula · 2020-10-08T08:50:26Z

x-pack/plugins/lens/public/plugin.ts

@@ -160,6 +161,8 @@ export class LensPlugin {
  start(core: CoreStart, startDependencies: LensPluginStartDependencies) {
    this.attributeService = getLensAttributeService(core, startDependencies);
    this.createEditorFrame = this.editorFrameService.start(core, startDependencies).createInstance;
+    // unregisters the OSS alias
+    startDependencies.visualizations.unRegisterAlias(OSS_PLUGIN_ID);


ℹ️ I unregister the oss alias on the plugin start to avoid race conditions, same applies for maps

stratoula · 2020-10-30T15:01:10Z

@alexfrancoeur we are very close to merging it! What I am missing are the URL params to track the clicks to the maps and lens landing pages. Can you provide them to me? 🙌

stratoula · 2020-11-02T08:31:41Z

@elasticmachine merge upstream

…la/kibana into visualization-wizard-new

alexfrancoeur · 2020-11-02T13:58:13Z

@stratoula as discussed in slack, I'll try and get you these by end of day. Thank you!!

dsmith001 · 2020-11-02T22:48:27Z

@alexfrancoeur we are very close to merging it! What I am missing are the URL params to track the clicks to the maps and lens landing pages. Can you provide them to me? 🙌

@stratoula as discussed in slack, I'll try and get you these by end of day. Thank you!!

Hi Team. I've been consulting with the marketing web team on how best to create these URL parameters in order to accurately track traffic from our OSS distro to these pages as well as considering how we've already approached this with things like the Kibana Newsfeed, etc. My recommendation is that we go with blade=kibanaossvizwizard

Example:https://www.elastic.co/what-is/kibana-lens?blade=kibanaossvizwizard

stratoula · 2020-11-03T07:08:36Z

Great @dsmith001, thank you a ton!

stratoula · 2020-11-03T07:10:00Z

@elasticmachine merge upstream

…g url param

timroes · 2020-11-04T09:57:36Z

@dsmith001 Do we have a URL migration system on elastic.co in place, i.e. so we can make sure if we would want to move that page to a different URL the old URL will always continue to work and just forward? Because if not, we'd instead link to a short link that we can update in case the URL on elastic.co will change, since we want to ensure the link is also working in every older Kibana version, where we might not be able to update the link, in case it would change.

dsmith001 · 2020-11-04T16:19:25Z

@timroes Yes, we have the ability to do URL forwards if a page's URL structure changes.

stratoula · 2020-11-04T16:25:24Z

@timroes Yes, we have the ability to do URL forwards if a page's URL structure changes.

That's great @dsmith001

stratoula · 2020-11-05T07:05:29Z

@elasticmachine merge upstream

flash1293

This PR looks awesome! I just have one question and a little layout nit

src/plugins/visualizations/public/vis_types/vis_type_alias_registry.ts

flash1293 · 2020-11-06T10:57:58Z

src/plugins/visualizations/public/wizard/dialog.scss

-  justify-content: center;
-  padding-bottom: $euiSize;
+  max-width: $modalWidth;
+  max-height: $modalHeight;


It looks a little weird to have the last row of items being cut of:

Would it make sense to increase the height slightly?

I will let @miukimiu to answer this as this is implemented as it was on the mocks provided by the designers. We wanted to not change the height between the different steps of the wizard and to keep it as smaller as we can #73418 (comment)

flash1293

Changes LGTM, didn't test again. The modal height thing doesn't look like a blocker for this PR to me.

kibanamachine · 2020-11-06T16:01:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 26b13ba

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`lensOss`	-	7	+7
`mapsOss`	-	7	+7
`visualizations`	134	153	+19
total			+33

async chunk count

id	before	after	diff
`visualizations`	0	1	+1

async chunks size

id	before	after	diff
`lens`	1.0MB	1.0MB	+1.0B
`maps`	2.8MB	2.8MB	+3.0B
`visualizations`	0.0B	56.7KB	+56.7KB
total			+56.7KB

distributable file count

id	before	after	diff
`default`	42725	42746	+21
`oss`	22421	22442	+21

page load bundle size

id	before	after	diff
`core`	545.1KB	545.3KB	+200.0B
`inputControlVis`	104.3KB	104.7KB	+341.0B
`lens`	49.7KB	50.0KB	+218.0B
`lensOss`	-	4.5KB	+4.5KB
`maps`	153.9KB	153.9KB	-13.0B
`mapsOss`	-	4.3KB	+4.3KB
`visTypeMarkdown`	14.5KB	14.6KB	+176.0B
`visTypeTimeseries`	132.7KB	132.8KB	+51.0B
`visTypeVega`	57.4KB	57.7KB	+328.0B
`visTypeVislib`	66.1KB	66.0KB	-75.0B
`visualizations`	205.3KB	170.4KB	-35.0KB
total			-25.0KB

History

💚 Build #86361 succeeded 7dd304b
💚 Build #86053 succeeded 00d92fe
💔 Build #86042 failed eb150a8
💚 Build #85464 succeeded 1b7884c
💚 Build #85064 succeeded 07d7a5e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [Visualizations] New vis wizard * Update functional tests * Create oss plugins for maps and lens and unregister alias function * Add new plugins to .i18nrc.json * Add readme and codeowners to the new plugins * update docs * fix tests * fix types * fixes * Update development docs * fix oss functional tests * Fix jest and x-pack functional tests * Fix functional test * changes on the layout * Cleanup and responsiveness * cleanup unecessary code * add common folder to the new OSS plugins * remove unecessary translations * Update limits.yml file * Fix basic label * Add experimental badge on controls vis * Nice improvements * fixes * Improving styles * Making modal go full height on smaller screens * Fixing sass lint warning * fix lint error * fix internationalization error * PR fixes * PR changes * Use useCallback where possible * Remove translations that need to be translated again * Lazy Load wizard modal * Remove legacyMapVisualizationWarning * Import the OSS plugins constants from the plugins * Export constant from lensOss * Change the new oss plugins from OSS to Oss * Add a new line to the kibana.json files of the new plugins * New nit fix * Fix spaces * Change the texts for the first step of the modal * Fix test * Fixes some of the PR comments * Add onClick funtionality to the entire aggregation based card * Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss * Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled * fix eslint error * Change groupTitles and descriptions * Change input vis description * Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint * Make the disabled cards badge clickable * Changes from code review * Fix functional tests failures * Rename groupTitle to titleInWizard to be more specific * Change vega vis note * minor design changes * fix problem with plugins list docs * Retrieve maps and lens landing page from docs service and add tracking url param * Fix funtional test for the new dashboard flow * Fix logic in alias registry for removing the discardOnRegister alias * no need to remove the alias entry from the discardOnRegister array Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: miukimiu <[email protected]> # Conflicts: # .github/CODEOWNERS # docs/developer/plugin-list.asciidoc # packages/kbn-optimizer/limits.yml # x-pack/scripts/functional_tests.js

stratoula added 15 commits October 5, 2020 16:45

[Visualizations] New vis wizard

caeda75

Update functional tests

bfb8192

Create oss plugins for maps and lens and unregister alias function

4cf7f50

merge with master and resolve conflicts

9159543

Add new plugins to .i18nrc.json

03cc038

Add readme and codeowners to the new plugins

4da28ce

update docs

eeecd68

fix tests

ca38a1d

fix types

0ecc5cb

fixes

2db1609

Update development docs

e11b4e5

Merge with master and fix conflicts

e2770df

fix oss functional tests

67e8ae3

Fix jest and x-pack functional tests

cdea42f

Fix functional test

b3a7a6d

elastic deleted a comment from kibanamachine Oct 7, 2020

stratoula added 2 commits October 7, 2020 10:58

changes on the layout

920bc66

Cleanup and responsiveness

4affc9b

kibanamachine and others added 2 commits October 7, 2020 10:56

Merge branch 'master' into visualization-wizard-new

b9dec37

cleanup unecessary code

ea2b4a3

stratoula commented Oct 8, 2020

View reviewed changes

src/plugins/lens_oss/public/plugin.ts Outdated Show resolved Hide resolved

stratoula commented Oct 8, 2020

View reviewed changes

src/plugins/maps_oss/public/plugin.ts Show resolved Hide resolved

Merge branch 'master' into visualization-wizard-new

5ba4431

stratoula commented Oct 8, 2020

View reviewed changes

stratoula added 4 commits October 8, 2020 11:53

add common folder to the new OSS plugins

676a982

remove unecessary translations

c6e9f62

Update limits.yml file

e1f7a95

Fix basic label

03fe88d

stratoula added 2 commits October 30, 2020 09:06

minor design changes

f1433ea

merge with master and resolv conflicts

83355bd

Merge with master and resolve conflicts

466e08b

kibanamachine and others added 3 commits November 2, 2020 03:31

Merge branch 'master' into visualization-wizard-new

3a9b4d1

fix problem with plugins list docs

cc2c53d

Merge branch 'visualization-wizard-new' of https://github.com/stratou…

07d7a5e

…la/kibana into visualization-wizard-new

kibanamachine and others added 3 commits November 3, 2020 02:10

Merge branch 'master' into visualization-wizard-new

66694af

Retrieve maps and lens landing page from docs service and add trackin…

105cc93

…g url param

Merge with master and resolve conflicts

1b7884c

kibanamachine and others added 2 commits November 5, 2020 02:05

Merge branch 'master' into visualization-wizard-new

eb150a8

Fix funtional test for the new dashboard flow

00d92fe

flash1293 reviewed Nov 6, 2020

View reviewed changes

stratoula added 2 commits November 6, 2020 13:35

Fix logic in alias registry for removing the discardOnRegister alias

7dd304b

no need to remove the alias entry from the discardOnRegister array

26b13ba

flash1293 approved these changes Nov 6, 2020

View reviewed changes

stratoula merged commit 5710f67 into elastic:master Nov 6, 2020

stratoula mentioned this pull request Nov 6, 2020

[7.x] [Visualize] New visualization wizard (#79627) #82858

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Visualize] New visualization wizard #79627

[Visualize] New visualization wizard #79627

stratoula commented Oct 6, 2020 •

edited

Loading

stratoula commented Oct 7, 2020

stratoula Oct 8, 2020 •

edited

Loading

stratoula Oct 8, 2020 •

edited

Loading

stratoula commented Oct 30, 2020

stratoula commented Nov 2, 2020

alexfrancoeur commented Nov 2, 2020

dsmith001 commented Nov 2, 2020

stratoula commented Nov 3, 2020

stratoula commented Nov 3, 2020

timroes commented Nov 4, 2020 •

edited

Loading

dsmith001 commented Nov 4, 2020

stratoula commented Nov 4, 2020

stratoula commented Nov 5, 2020

flash1293 left a comment

flash1293 Nov 6, 2020

stratoula Nov 6, 2020

flash1293 left a comment

kibanamachine commented Nov 6, 2020

[Visualize] New visualization wizard #79627

[Visualize] New visualization wizard #79627

Conversation

stratoula commented Oct 6, 2020 • edited Loading

Summary

Checklist

For maintainers

stratoula commented Oct 7, 2020

stratoula Oct 8, 2020 • edited Loading

Choose a reason for hiding this comment

stratoula Oct 8, 2020 • edited Loading

Choose a reason for hiding this comment

stratoula commented Oct 30, 2020

stratoula commented Nov 2, 2020

alexfrancoeur commented Nov 2, 2020

dsmith001 commented Nov 2, 2020

stratoula commented Nov 3, 2020

stratoula commented Nov 3, 2020

timroes commented Nov 4, 2020 • edited Loading

dsmith001 commented Nov 4, 2020

stratoula commented Nov 4, 2020

stratoula commented Nov 5, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Nov 6, 2020

Choose a reason for hiding this comment

stratoula Nov 6, 2020

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

kibanamachine commented Nov 6, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunk count

async chunks size

distributable file count

page load bundle size

History

stratoula commented Oct 6, 2020 •

edited

Loading

stratoula Oct 8, 2020 •

edited

Loading

stratoula Oct 8, 2020 •

edited

Loading

timroes commented Nov 4, 2020 •

edited

Loading